fix: validate supervisorctl exit code #3999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The supervisorctl status is actually exit with 3, so handle this gracefully. Fixes WeblateOrg#3997 Replaces WeblateOrg#3996
There was a problem hiding this comment.
Pull request overview
This PR fixes the health check script to properly handle supervisorctl exit codes. Previously, the script would fail when supervisorctl returned exit code 3, which happens when one or more supervised processes are not running (specifically, the "check" service which is designed to exit after completion).
Key changes:
- Removed
set -eto allow explicit exit code handling - Added logic to capture and validate supervisorctl exit codes, accepting both 0 (success) and 3 (expected for stopped "check" service)
- Improved error reporting to show the actual exit code when supervisorctl fails
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Maks1mS
approved these changes
Dec 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The supervisorctl status is actually exit with 3, so handle this gracefully.
Fixes #3997
Replaces #3996