fix(googlev3): ensure glossary path is set properly #17526
Merged
+7
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the Google Cloud Translation Advanced integration where glossary-based translations were failing because the code was passing only the glossary name (ID) instead of the required full resource path to the Google Cloud Translation API.
Key Changes:
- Added proper conversion of glossary ID to full resource path before passing to the API
- Added null check to handle cases where no glossary is available
Member
|
Merged, thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Advanced Google Translate with glossary did not function correctly because the integration passed only the glossary name (ID) rather than the required full glossary resource path. This change ensures the full path is used, restoring correct glossary-based translations.