Skip to content

Conversation

@nijel
Copy link
Member

@nijel nijel commented Jan 7, 2026

Will be needed after translate/translate#5972 for proper segmentation.

Will be needed after translate/translate#5972
for proper segmentation.
@nijel nijel added this to the 5.15.2 milestone Jan 7, 2026
@nijel nijel self-assigned this Jan 7, 2026
@codecov
Copy link

codecov bot commented Jan 7, 2026

❌ 3 Tests Failed:

Tests completed Failed Passed Skipped
5447 3 5444 684
View the full list of 3 ❄️ flaky test(s)
weblate.formats.tests.test_convert.PlainTextFormatTest::test_convert

Flake rate in main: 11.73% (Passed 158 times, Failed 21 times)

Stack Traces | 0.071s run time
self = <weblate.formats.tests.test_convert.PlainTextFormatTest testMethod=test_convert>

    def test_convert(self) -> None:
        if not self.CONVERT_TEMPLATE:
            self.skipTest(
                f"Test template not provided for {self.format_class.format_id}"
            )
        translation = template = None
        try:
            # Generate test files
            with NamedTemporaryFile(
                encoding="utf-8", delete=False, mode="w+"
            ) as template:
                template.write(self.CONVERT_TEMPLATE)
            with NamedTemporaryFile(
                encoding="utf-8", delete=False, mode="w+"
            ) as translation:
                translation.write(self.CONVERT_TRANSLATION)
    
            # Parse
            storage = self.format_class(
                translation.name,
                template_store=self.format_class(template.name, is_template=True),
                existing_units=self.CONVERT_EXISTING,
            )
    
            # Ensure it is parsed correctly
            self.assertEqual(len(storage.content_units), 2)
            unit1, unit2 = storage.content_units
            self.assertEqual(unit1.source, "Hello")
            self.assertEqual(unit1.target, "Ahoj")
            self.assertEqual(unit2.source, "Bye")
            self.assertEqual(unit2.target, "")
    
            # Translation
            unit2.set_target("Nazdar")
            unit2.set_state(STATE_TRANSLATED)
    
            # Save
>           storage.save()

.../formats/tests/test_convert.py:81: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
weblate/formats/convert.py:138: in save
    self.save_atomic(self.storefile, self.save_content)
weblate/formats/base.py:530: in save_atomic
    callback(temp)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <weblate.formats.convert.PlainTextFormat object at 0x1406002b0>
handle = <_TemporaryFileWrapper file=<_io.BufferedRandom name='.../kmfmhnl95kx1c8x321z7twbw0000gn/T/tmpag2jtblb_oa0esnn'>>

    def save_content(self, handle) -> None:
        """Store content to file."""
        templatename = self.template_store.storefile
        if hasattr(templatename, "name"):
            templatename = templatename.name
        with open(templatename, "rb") as templatefile:
>           converter = po2txt(
                input_file=self.store,
                output_file=None,
                template_file=templatefile,
                flavour=self.flavour,
            )
E           TypeError: po2txt.__init__() got an unexpected keyword argument 'flavour'

weblate/formats/convert.py:589: TypeError
weblate.formats.tests.test_convert.PlainTextFormatTest::test_edit

Flake rate in main: 11.73% (Passed 158 times, Failed 21 times)

Stack Traces | 0.126s run time
self = <weblate.formats.tests.test_convert.PlainTextFormatTest testMethod=test_edit>

    def test_edit(self) -> None:
>       self._test_save(self.EDIT_TARGET)

.../formats/tests/test_formats.py:282: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
.../formats/tests/test_formats.py:265: in _test_save
    storage.save()
weblate/formats/convert.py:138: in save
    self.save_atomic(self.storefile, self.save_content)
weblate/formats/base.py:530: in save_atomic
    callback(temp)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <weblate.formats.convert.PlainTextFormat object at 0x14060c380>
handle = <_TemporaryFileWrapper file=<_io.BufferedRandom name='.../T/tmppbyxfv1jweblate/cs.txto4_i80m2'>>

    def save_content(self, handle) -> None:
        """Store content to file."""
        templatename = self.template_store.storefile
        if hasattr(templatename, "name"):
            templatename = templatename.name
        with open(templatename, "rb") as templatefile:
>           converter = po2txt(
                input_file=self.store,
                output_file=None,
                template_file=templatefile,
                flavour=self.flavour,
            )
E           TypeError: po2txt.__init__() got an unexpected keyword argument 'flavour'

weblate/formats/convert.py:589: TypeError
weblate.formats.tests.test_convert.PlainTextFormatTest::test_save

Flake rate in main: 11.73% (Passed 158 times, Failed 21 times)

Stack Traces | 0.085s run time
self = <weblate.formats.tests.test_convert.PlainTextFormatTest testMethod=test_save>

    def test_save(self) -> None:
>       self._test_save()

.../formats/tests/test_formats.py:279: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
.../formats/tests/test_formats.py:265: in _test_save
    storage.save()
weblate/formats/convert.py:138: in save
    self.save_atomic(self.storefile, self.save_content)
weblate/formats/base.py:530: in save_atomic
    callback(temp)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <weblate.formats.convert.PlainTextFormat object at 0x1433ca8f0>
handle = <_TemporaryFileWrapper file=<_io.BufferedRandom name='.../T/tmpa5tklzleweblate/cs.txtweem9i99'>>

    def save_content(self, handle) -> None:
        """Store content to file."""
        templatename = self.template_store.storefile
        if hasattr(templatename, "name"):
            templatename = templatename.name
        with open(templatename, "rb") as templatefile:
>           converter = po2txt(
                input_file=self.store,
                output_file=None,
                template_file=templatefile,
                flavour=self.flavour,
            )
E           TypeError: po2txt.__init__() got an unexpected keyword argument 'flavour'

weblate/formats/convert.py:589: TypeError

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant