fix: add intermediate page for project-language upload #17534

nijel · 2026-01-07T14:18:28Z

This doesn't provide upload, but tells users where to perform it. Temporary solution util #4283 is implemented.

Fixes #15695

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

weblate/auth/permissions.py

Copilot · 2026-01-07T16:11:41Z

weblate/templates/language-project.html

+        {% if user_can_upload_translation %}
+          <li>
+            <a class="dropdown-item" data-bs-target="#upload" data-bs-toggle="tab">{% translate "Upload translation" %}</a>
+          </li>
+        {% endif %}


The new upload tab functionality for project-language pages lacks test coverage. Consider adding a test to verify that:

The upload tab appears when a user has the appropriate permissions

The upload tab is hidden when a user lacks permissions

The informational message is displayed correctly

The permission check doesn't cause runtime errors with ProjectLanguage objects

weblate/templates/language-project.html

This doesn't provide upload, but tells users where to perform it. Temporary solution util WeblateOrg#4283 is implemented. Fixes WeblateOrg#15695

Co-authored-by: Copilot <[email protected]>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

weblate/templates/language-project.html

Co-authored-by: Copilot <[email protected]>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

weblate/templates/language-project.html

Copilot · 2026-01-07T18:36:41Z

weblate/auth/permissions.py

+    return check_can_edit(user, permission, obj) and (
        # Normal upload
-        check_edit_approved(user, "unit.edit", translation)
+        check_edit_approved(user, "unit.edit", obj)
        # Suggestion upload
-        or check_suggestion_add(user, "suggestion.add", translation)
+        or check_suggestion_add(user, "suggestion.add", obj)
        # Add upload
-        or check_suggestion_add(user, "unit.add", translation)
+        or check_suggestion_add(user, "unit.add", obj)
        # Source upload
-        or translation.is_source
+        or (isinstance(obj, Translation) and obj.is_source)
    )


The permission checks for check_upload now accept ProjectLanguage, but the function doesn't properly handle all the permission validation logic for ProjectLanguage objects. Specifically, when obj is a ProjectLanguage, the function proceeds directly to line 510 where it calls check_can_edit(user, permission, obj) and then checks various upload permissions.

However, the checks at lines 512-518 call functions like check_edit_approved, check_suggestion_add, etc., which expect either a Translation or a ProjectLanguage. While check_suggestion_add has been updated to support ProjectLanguage, these permission checks are designed to work on individual translations, not on project-language combinations. This could lead to confusing or incorrect permission results.

Consider adding explicit handling for ProjectLanguage in the check_upload function that either:

Returns early with an appropriate message explaining that actual upload is not supported at this level (since this is meant to be an informational page)

Implements proper permission logic that makes sense for a project-language context

Copilot · 2026-01-07T18:36:41Z

weblate/auth/permissions.py

 @register_perm("upload.perform")
 def check_upload(
-    user: User, permission: str, translation: Translation
+    user: User, permission: str, obj: Translation | ProjectLanguage
 ) -> bool | PermissionResult:
    """
    Check whether user can perform any upload operation.

    The actual check for the method is implemented in
    weblate.trans.util.check_upload_method_permissions.
    """
-    # Source upload
-    if translation.is_source and not user.has_perm("source.edit", translation):
-        return Denied(gettext("Insufficient privileges for editing source strings."))
-    # Bilingual source translations
-    if (
-        translation.is_source
-        and not translation.is_template
-        and not issubclass(translation.component.file_format_cls, BilingualUpdateMixin)
-    ):
-        return Denied(
-            gettext("The file format does not support updating source strings.")
-        )
-    if translation.component.is_glossary:
-        permission = "glossary.upload"
-    return check_can_edit(user, permission, translation) and (
+    if isinstance(obj, Translation):
+        # Source upload
+        if obj.is_source and not user.has_perm("source.edit", obj):
+            return Denied(
+                gettext("Insufficient privileges for editing source strings.")
+            )
+        # Bilingual source translations
+        if (
+            obj.is_source
+            and not obj.is_template
+            and not issubclass(obj.component.file_format_cls, BilingualUpdateMixin)
+        ):
+            return Denied(
+                gettext("The file format does not support updating source strings.")
+            )
+        if obj.component.is_glossary:
+            permission = "glossary.upload"
+
+    return check_can_edit(user, permission, obj) and (
        # Normal upload
-        check_edit_approved(user, "unit.edit", translation)
+        check_edit_approved(user, "unit.edit", obj)
        # Suggestion upload
-        or check_suggestion_add(user, "suggestion.add", translation)
+        or check_suggestion_add(user, "suggestion.add", obj)
        # Add upload
-        or check_suggestion_add(user, "unit.add", translation)
+        or check_suggestion_add(user, "unit.add", obj)
        # Source upload
-        or translation.is_source
+        or (isinstance(obj, Translation) and obj.is_source)
    )


The changes to support ProjectLanguage in permission checks (check_upload, check_suggestion_add, and check_edit_approved) lack test coverage. Given that comprehensive permission tests exist in weblate/auth/tests/test_permissions.py, new tests should be added to verify that the permission checks work correctly when called with a ProjectLanguage object.

Consider adding tests that verify:

upload.perform permission works correctly with ProjectLanguage objects

suggestion.add permission works correctly with ProjectLanguage objects

unit.edit permission works correctly with ProjectLanguage objects

The informational upload tab is displayed correctly when permissions are granted/denied

Copilot · 2026-01-07T18:36:42Z

weblate/utils/stats.py

+        return True
+


The enable_suggestions property for ProjectLanguage is hardcoded to return True, which may not reflect the actual configuration of the components within the project-language combination. Some components within the project might have enable_suggestions set to False, or might have workflow settings that disable suggestions. This could lead to showing the upload tab to users even when suggestions are not actually enabled for any of the components in this project-language combination.

Consider checking if any translations within the project-language have suggestions enabled, or documenting why this always returns True is an acceptable approach for this use case.

Suggested change

return True

"""Return whether suggestions are enabled for this project-language.

Suggestions are considered enabled if any related component for this

project-language has suggestions enabled, or if workflow settings

explicitly enable them. This avoids advertising suggestions in the UI

when none of the components actually support them.

"""

# Check per-component configuration via related translations.

for translation in self.translation_set:

component = getattr(translation, "component", None)

if component is not None and getattr(component, "enable_suggestions", False):

return True

# Fallback to workflow settings, if they define suggestion behavior.

workflow = self.workflow_settings

if workflow is not None and hasattr(workflow, "enable_suggestions"):

return bool(getattr(workflow, "enable_suggestions"))

return False

Co-authored-by: Copilot <[email protected]>

weblate/templates/language-project.html

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

weblate/auth/permissions.py:478

The check_suggestion_add function now accepts ProjectLanguage but only checks for contributor agreement when the object is a Translation. However, when a ProjectLanguage is passed, the function will skip the agreement check entirely and proceed directly to the permission check. This could allow users to bypass contributor agreement requirements at the project-language level. Consider adding proper handling for ProjectLanguage objects or explicitly documenting why this check is intentionally skipped for this type.

    if (
        not user.is_bot
        and isinstance(obj, Translation)
        and obj.component.agreement
        and not ContributorAgreement.objects.has_agreed(user, obj.component)
    ):
        return False

codecov · 2026-01-07T19:41:26Z

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 91.75%. Comparing base (d12614c) to head (05e9260).
⚠️ Report is 8 commits behind head on main.

Files with missing lines	Patch %	Lines
weblate/utils/stats.py	66.66%	1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (90.90%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nijel added this to the 5.15.2 milestone Jan 7, 2026

nijel self-assigned this Jan 7, 2026

nijel requested a review from Copilot January 7, 2026 14:18

Copilot started reviewing on behalf of nijel January 7, 2026 14:19 View session

Copilot AI reviewed Jan 7, 2026

View reviewed changes

nijel requested a review from Copilot January 7, 2026 16:07

Copilot started reviewing on behalf of nijel January 7, 2026 16:07 View session

Copilot AI reviewed Jan 7, 2026

View reviewed changes

fix: add intermediate page for project-language upload

21955e3

This doesn't provide upload, but tells users where to perform it. Temporary solution util WeblateOrg#4283 is implemented. Fixes WeblateOrg#15695

nijel force-pushed the prj-lang-upload branch from 6ec9372 to 21955e3 Compare January 7, 2026 18:03

Update weblate/templates/language-project.html

9ac9af5

Co-authored-by: Copilot <[email protected]>

nijel requested a review from Copilot January 7, 2026 18:04

Copilot started reviewing on behalf of nijel January 7, 2026 18:10 View session

Copilot AI reviewed Jan 7, 2026

View reviewed changes

weblate/templates/language-project.html Outdated Show resolved Hide resolved

Update weblate/templates/language-project.html

9f4e192

Co-authored-by: Copilot <[email protected]>

nijel requested a review from Copilot January 7, 2026 18:30

Copilot started reviewing on behalf of nijel January 7, 2026 18:32 View session

Copilot AI reviewed Jan 7, 2026

View reviewed changes

Update weblate/templates/language-project.html

d1a1732

Co-authored-by: Copilot <[email protected]>

nijel commented Jan 7, 2026

View reviewed changes

weblate/templates/language-project.html Outdated Show resolved Hide resolved

nijel commented Jan 7, 2026

View reviewed changes

weblate/templates/language-project.html Outdated Show resolved Hide resolved

Apply suggestions from code review

05e9260

nijel requested a review from Copilot January 7, 2026 18:46

Copilot started reviewing on behalf of nijel January 7, 2026 18:47 View session

Copilot AI reviewed Jan 7, 2026

View reviewed changes

nijel merged commit e2f8e63 into WeblateOrg:main Jan 8, 2026
59 of 60 checks passed

nijel deleted the prj-lang-upload branch January 8, 2026 04:31

-        return True
+        """Return whether suggestions are enabled for this project-language.
+        Suggestions are considered enabled if any related component for this
+        project-language has suggestions enabled, or if workflow settings
+        explicitly enable them. This avoids advertising suggestions in the UI
+        when none of the components actually support them.
+        """
+        # Check per-component configuration via related translations.
+        for translation in self.translation_set:
+            component = getattr(translation, "component", None)
+            if component is not None and getattr(component, "enable_suggestions", False):
+                return True
+        # Fallback to workflow settings, if they define suggestion behavior.
+        workflow = self.workflow_settings
+        if workflow is not None and hasattr(workflow, "enable_suggestions"):
+            return bool(getattr(workflow, "enable_suggestions"))
+        return False

Uh oh!

fix: add intermediate page for project-language upload #17534

fix: add intermediate page for project-language upload #17534

Uh oh!

Conversation

nijel commented Jan 7, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

codecov bot commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

codecov bot commented Jan 7, 2026 •

edited

Loading