Add ObjCFormatCheck for Objective-C format strings

docs/changes.rst

@@ -15,6 +15,7 @@ Weblate 5.17
 * Improved LLM interfaces for better reliability.
 * Improved logic for adding monolingual plurals in :doc:`/formats/gettext`.
 * Improved error messages in some of the :ref:`api` endpoints.
+* Added :ref:`check-objc-format`.
 * Improved performance of project and category search result pages with very large match sets.
 * :envvar:`WEBLATE_COMMIT_PENDING_HOURS` is now available in Docker container.
 

docs/user/checks.rst

@@ -104,4 +104,23 @@ Please file a bug if anything is reported in error.
    * :ref:`custom-checks`
 
 
+.. _check-objc-format:
+
+Objective-C format
+------------------
+
+.. versionadded:: 5.17
+
+.. check:: objc-format
+
+Checks whether Objective-C format strings match between source and translation.
+
+For example, ``%@`` for objects, ``%d`` for integers, or positional variants like ``%1$@``.
+
+.. seealso::
+
+`Objective-C String Format Specifiers <https://developer.apple.com/library/archive/documentation/Cocoa/Conceptual/Strings/Articles/formatSpecifiers.html>`_
+
+
+
 .. include:: /snippets/checks-autogenerated.rst

weblate/checks/format.py

@@ -92,6 +92,20 @@
     re.VERBOSE,
 )
 
+OBJC_PRINTF_MATCH = re.compile(
+    r"""
+    %(                          # initial %
+          (?:(?P<ord>\d+)\$)?   # variable order, like %1$@
+    (?P<fullvar>
+        [ +#'-]*                # flags
+        (?:\d+)?                # width
+        (?:\.\d+)?              # precision
+        (hh|h|l|ll)?            # length formatting
+        (?P<type>[a-zA-Z@%])    # type (%s, %d, %@ etc.)
+        |)
+    )""",
+    re.VERBOSE,
+)
 # index, width and precision can be '*', in which case their value
 # will be read from the next element in the Args array
 PASCAL_FORMAT_MATCH = re.compile(
@@ -349,6 +363,11 @@
         name_format_is_position_based,
         extract_string_simple,
     ),
+    "objc-format": (
+        OBJC_PRINTF_MATCH,
+        c_format_is_position_based,
+        extract_string_simple,
+    ),
 }
 
 
@@ -517,11 +536,11 @@
         errors: list[StrOrPromise] = []
 
         # Merge plurals
         results: MissingExtraDict = defaultdict(list)
         for result in checks:
             if result:
                 for key, value in result.items():
                     results[key].extend(value)
         if results:
             errors.extend(self.format_result(results))
         if errors:
@@ -608,6 +627,15 @@
     description = gettext_lazy("C format string does not match source.")
 
 
+class ObjCFormatCheck(BasePrintfCheck):
+    """Check for Objective-C format string."""
+
+    check_id = "objc_format"
+    name = gettext_lazy("Objective-C format")
+    description = gettext_lazy("Objective-C format string does not match source.")
+    version_added = "5.17"
+
+
 class PerlBraceFormatCheck(BaseFormatCheck):
     """Check for Perl brace format string."""
 

weblate/checks/models.py

@@ -73,6 +73,7 @@ class WeblateChecksConf(AppConf):
         "weblate.checks.format.PythonBraceFormatCheck",
         "weblate.checks.format.PHPFormatCheck",
         "weblate.checks.format.CFormatCheck",
+        "weblate.checks.format.ObjCFormatCheck",
         "weblate.checks.format.PerlFormatCheck",
         "weblate.checks.format.PerlBraceFormatCheck",
         "weblate.checks.format.JavaScriptFormatCheck",

weblate/checks/tests/test_format_checks.py

@@ -34,7 +34,7 @@
 from weblate.checks.models import Check
 from weblate.checks.qt import QtFormatCheck, QtPluralCheck
 from weblate.checks.ruby import RubyFormatCheck
-from weblate.checks.tests.test_checks import CheckTestCase, MockUnit
+from weblate.checks.tests.test_checks import BaseFormatTest, CheckTestCase, MockUnit
 from weblate.lang.models import Language
 from weblate.trans.models import Component, Project, Translation, Unit
 from weblate.trans.tests.test_views import FixtureTestCase
@@ -1917,3 +1917,20 @@
                 ["Recognition {}% ({}/{})"], MockUnit(flags="python-brace-format")
             )
         )
+
+
+class ObjCFormatTest(BaseFormatTest):
+    CHECK = "objc_format"
+
+    def test_format(self):
+
+        self.check_match("Hello %@", "Hello %@")
+        self.check_match("Order %1$@ %2$d", "Order %1$@ %2$d")
+        self.check_match("Value is %1$.2f", "Value is %1$.2f")
+
+        self.check_match("%1$@ %2$@", "%2$@ %1$@")
+
+        self.check_fail("Hello %@", "Hello %s")
+        self.check_fail("Total: %d", "Total: %@")
+        self.check_fail("Missing %@", "Missing")
+        self.check_fail("Hello", "Hello %@")