Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds output truncation to prevent oversized responses and applies it to the evaluation runner to avoid 413 errors.
- Introduce
DEFAULT_MAX_LINESandDEFAULT_MAX_CHARSconstants. - Implement
truncate_outputhelper to trim by lines and/or characters with a descriptive prefix. - Update
run_evaluationto return the truncated output.
Comments suppressed due to low confidence (1)
weco/utils.py:131
- Add unit tests for
truncate_outputto cover scenarios where only lines exceed, only characters exceed, both conditions, and no truncation.
def truncate_output(output: str, max_lines: int = DEFAULT_MAX_LINES, max_chars: int = DEFAULT_MAX_CHARS) -> str:
DhruvSrikanth
approved these changes
Jul 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some execution results have too long output and leading the 413 error
╭───────────────────────────── Optimization Error ─────────────────────────────╮ │ Error: 413 Client Error: Request Entity Too Large for url: │ │ https://api.weco.ai/v1/runs/a0fa10d7-3e4e-487b-b52e-5f8ba4cc0c68/suggest │ ╰──────────────────────────────────────────────────────────────────────────────╯