Merged
Conversation
…sub-panel within the summary panel
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refines retry logic to only target rate limits, overhauls the top-left summary panel to include a run name and “thinking” content (removing the separate plan panel), and sharpens error messages across modules.
- Restrict API retries to status 429 and streamline heartbeat logging
- Redesign
SummaryPanelto showrun_nameand dynamic thinking content; dropPlanPanel - Improve clarity of user-facing error messages in utils, CLI, chatbot, auth, and API layers
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| weco/utils.py | Clarified error messages in LLM key detection and file writes |
| weco/panels.py | Overhauled SummaryPanel to display run name and thinking; removed PlanPanel |
| weco/optimizer.py | Integrated run_name handling, removed PlanPanel references, refined heartbeat logging |
| weco/cli.py | Enhanced invalid-directory error message |
| weco/chatbot.py | Extended retry and unexpected-error messages |
| weco/auth.py | Unified credential file error/warning prints |
| weco/api.py | Limited retry strategy to 429, unified exception handling, adjusted heartbeat logs |
Comments suppressed due to low confidence (4)
weco/panels.py:55
- Add unit tests covering
set_run_name,update_thinking,clear_thinking, and both display paths inget_displayto ensure the new run_name and thinking_content logic is exercised.
def set_run_name(self, run_name: str):
weco/utils.py:87
- This error message implies a file-path issue, but the TypeError is raised when content is not a str or dict. Consider restoring specificity: e.g., "Content must be str or Dict[str, Any]" or include both causes.
raise TypeError("Error writing to file. Please verify the file path and try again.")
weco/panels.py:101
- When
final_messageis None, the panel no longer shows the optimization goal (previouslyself.goal). Reintroduce a goal row usingmaximizeandmetric_name, for example: "[bold cyan]Goal:[/] {'Maximizing' if self.maximize else 'Minimizing'} {self.metric_name}...".
summary_table.add_row("")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes