Skip to content

Fix AOT compatibility in streaming mode #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 3 commits into from
Closed

Fix AOT compatibility in streaming mode #128

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
00a6aa0
Initial plan
Copilot Dec 3, 2025
2e9fb6f
fix: Use UTF-8 encoding for AOT compatibility in streaming mode
Copilot Dec 3, 2025
d6e1072
docs: Improve AOT compatibility comments for clarity
Copilot Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions src/HTTPie/Implement/RequestExecutor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,12 +280,9 @@ private async Task InvokeStreamingRequest(HttpClient httpClient, HttpContext htt
{
await using var stream = await responseMessage.Content.ReadAsStreamAsync(cancellationToken);

// Get encoding from Content-Type header or default to UTF-8
var encoding = responseMessage.Content.Headers.ContentType?.CharSet is { } charset
? System.Text.Encoding.GetEncoding(charset)
: System.Text.Encoding.UTF8;

using var reader = new StreamReader(stream, encoding);
// Use UTF-8 encoding for AOT compatibility (Encoding.GetEncoding is not AOT-safe)
// Trade-off: responses using non-UTF-8 encodings may not display correctly in streaming mode
using var reader = new StreamReader(stream, Encoding.UTF8);

var bodyBuilder = new StringBuilder();
string? line;
Expand All @@ -295,9 +292,9 @@ private async Task InvokeStreamingRequest(HttpClient httpClient, HttpContext htt
bodyBuilder.AppendLine(line);
}

// Store the body for potential later use
// Store the streamed content (re-encoded as UTF-8 bytes for consistency)
responseModel.Body = bodyBuilder.ToString();
responseModel.Bytes = encoding.GetBytes(responseModel.Body);
responseModel.Bytes = Encoding.UTF8.GetBytes(responseModel.Body);
}
else
{
Expand Down