Skip to content

Comments

Add sup pattern file#337

Merged
WerWolv merged 3 commits intoWerWolv:masterfrom
miasinterestinglife:master
Jan 9, 2025
Merged

Add sup pattern file#337
WerWolv merged 3 commits intoWerWolv:masterfrom
miasinterestinglife:master

Conversation

@miasinterestinglife
Copy link
Contributor

This is a Pattern to mostly parse PGS Subtitles (in .sup format). I don't know what to do about the MIME Type, as PGS subtitles don't have one as far as i know.

@WerWolv
Copy link
Owner

WerWolv commented Jan 9, 2025

Hey, Thanks a lot!

Don't worry about the MIME type. If there isn't one, just leave it as it is. The magicpragma will take care of the detection.
If possible, could you upload a test file to /tests/patterns/test_data so we can run the unit tests on your pattern in the future? Also please add the pattern to the table in the readme and if you like add a #pragma author <Your Name>to the pattern so we can give credit to you in the UI :)

@miasinterestinglife
Copy link
Contributor Author

That shoud be it, right?

@miasinterestinglife
Copy link
Contributor Author

miasinterestinglife commented Jan 9, 2025

It would be possible to add decoding of the actual images at a later point, but it would be a huge undertaking. Decoding (and the entire format) is described here: https://blog.thescorpius.com/index.php/2017/07/15/presentation-graphic-stream-sup-files-bluray-subtitle-format/#comment-480 (there is some minor mistakes that were corrected in the comments)

@WerWolv
Copy link
Owner

WerWolv commented Jan 9, 2025

Thanks! Looks good yeah :)

Having it decode the images would be really cool but by no means required in the first version. I'm happy to merge any future PRs improving upon it though!

@WerWolv WerWolv merged commit 1f6c701 into WerWolv:master Jan 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants