Easier keyboard pattern filtering selection#2300
Open
shewitt-au wants to merge 10 commits intoWerWolv:masterfrom
Open
Easier keyboard pattern filtering selection#2300shewitt-au wants to merge 10 commits intoWerWolv:masterfrom
shewitt-au wants to merge 10 commits intoWerWolv:masterfrom
Conversation
…/github.com/shewitt-au/SteveImHex into easier_keyboard_pattern_filtering_selection
…/github.com/shewitt-au/SteveImHex into easier_keyboard_pattern_filtering_selection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem addressed
No keyboard naviagtion in the "Import Pattern File..." popup (from right click menu in "Pattern editor"). There seems to be poor support for kbnav in general, but I'm always using this popup when debugging, and I find this makes things earier.
Changed behaviour
The up and down keys now change the selected pattern. You can edit the filter but still use the up and down keys to select filtered results. The enter key loads the pattern.
Caveat
This PR is mainly meant as a feature demonstration. There's likely a better way to do this. ImHex is my first exposure to Dear ImGui.
Implementation description
I tried to keep the multiple selection code path the same. I've added a "// TODO" in the multi selection code path to mark code which to me looks funny.