Update polish translation #2324
Conversation
| "hex.builtin.provider.udp": "UDP Server", | ||
| "hex.builtin.provider.udp.name": "UDP Server on Port {}", | ||
| "hex.builtin.provider.udp.port": "Server Port", | ||
| "hex.builtin.provider.udp.timestamp": "Timestamp", |
There was a problem hiding this comment.
Maybe these changes are here by accident? I would imagine that only files of the language the pr addresses should be changed. If you didn't mean to change this file please remove the changes by committing the file with the entries included.
Actually I just noticed that unit tests are failing because it is missing these entries so they need to be restored to pass unit tests.
There was a problem hiding this comment.
I must have done it by accident – only those entries, nothing else?
Also, I can create a new pull request to add the formater.py script again, because the old one was closed when I created this new pull request.
There was a problem hiding this comment.
only those entries, nothing else?
I think so. Make sure you are not modifying any language files other than the ones for the PR. Could you also add the formatter.py script here or does it need to be in its own PR? either way should be fine.
|
Were those keys already in the JSON file earlier? I checked my local version and my fork — they weren’t there. But now I can see them in the main repository. Tomorrow I’ll try to update the pull request — this time with the corrected keys, an improved language version, and the script. |
|
Those UDP keys were all added in 03884dd |
|
Note that the UDP keys were added on May 29, before you created this branch on June 9, even before your previous branch was merged and that merge contains the UDP keys. Looking at your very first commit for this branch it looks like you added files via upload and accidentally added an outdated version of the English language json file that didn't have the UDP keys. Updating the repository will not revert the keys back because to git these are intended changes. You can either undo the commit or you can simply add the UDP keys to the English language json and commit/push the change to your branch. In either case this would result in the unintended changes to disappear. |
|
Sorry for the delay — I probably won’t be able to finish my pull request this week, but it will most likely be ready next week. In the meantime, please don’t compile ImHex with the Polish language enabled, as it’s not ready yet. |
|
@WerWolv @paxcut Hello, sorry for the delay. I noticed that the language files have changed a bit structurally. I’ve already filled in all the keys in builtin, and I’d like to ask if there are any other keys that I should complete. My script is also almost ready — I just need to adjust the parser so that it formats the new JSON better. |
|
Hey! Yeah sorry, I revamped the whole system a bit. You can pretty much just remove all the metadata from your files and it will work. It's now just one large json object with translation keys -> translations. I also got Weblate setup and running again so if you want to update it, you can do so through https://weblate.werwolv.net. Should hopefully be a bit easier than with the lang script |
Fixed some keys and formatted all JSON files using Formatter.py script."