Skip to content

Feature: add hooks to let Views to get notified when they are opened or closed #2493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Feature: add hooks to let Views to get notified when they are opened or closed #2493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e8aa2a
Add onOpen and onClose methods to View for lifecycle notification.
davidgiven Oct 31, 2025
3471056
Merge branch 'WerWolv:master' into master
davidgiven Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions lib/libimhex/include/hex/ui/view.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,17 @@ namespace hex {
void trackViewState();
void setFocused(bool focused);

protected:
/**
* @brief Called when this view is opened (i.e. made visible).
*/
virtual void onOpen() {}

/**
* @brief Called when this view is closed (i.e. made invisible).
*/
virtual void onClose() {}

public:
class Window;
class Special;
Expand Down
6 changes: 5 additions & 1 deletion lib/libimhex/source/ui/view.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,13 @@ namespace hex {

void View::trackViewState() {
if (m_windowOpen && !m_prevWindowOpen)
{
this->setWindowJustOpened(true);
else if (!m_windowOpen && m_prevWindowOpen)
this->onOpen();
} else if (!m_windowOpen && m_prevWindowOpen) {
this->setWindowJustClosed(true);
this->onClose();
}
m_prevWindowOpen = m_windowOpen;
}

Expand Down
Loading