feat: main views retain focus on ui interactions#2650
Open
feat: main views retain focus on ui interactions#2650
Conversation
Currently, interactions with the user interface, like changing providers, opening menus or even resizing windows, take the focus away from the main views. The PR adds the ability to retake the focus for window views and for the hex and text editors in particular but more can be added if needed. The views have to be able to obtain the name of the child windows you want to retain focus. If no name is provided then focus is not recovered to any view and remains in the UI objext.
…since they wee not needed after all. Using the vector of windows ordered by focus removed the need to use the names of the child windows. Now the code works for all window views, but it is not obvious because most window views don't have children and giving focus back to widgets is not enough, you also need to set them to be active and I don't know how to do that from the view class.
…tive status using Tab key.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, interactions with the user interface, like changing providers, opening menus or even resizing windows, take the focus away from the main views. The PR adds the ability to retake the focus for window views and for the hex and text editors in particular but more can be added if needed. The views have to be able to obtain the name of the child windows you want to retain focus. If no name is provided then focus is not recovered to any view and remains in the UI object.