Improve handling of imhex_patterns_SOURCE_DIR#2681
Open
neptuwunium wants to merge 1 commit intoWerWolv:masterfrom
Open
Improve handling of imhex_patterns_SOURCE_DIR#2681neptuwunium wants to merge 1 commit intoWerWolv:masterfrom
neptuwunium wants to merge 1 commit intoWerWolv:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem description
If building without ImHex Patterns at all, the install phase will error out with missing files.
This is a very niche situation, I know. It's what happens in my Gentoo overlay since I separate patterns into a separate package.
Implementation description
Resets imhex_patterns_SOURCE_DIR to an empty string so that installation can be omitted in a later step.