fix: Some variables are incorrectly highlighted as errors#2690
Merged
fix: Some variables are incorrectly highlighted as errors#2690
Conversation
Non-auto function arguments of custom types defined inside a namespace made the highlighter unable to check if member uses inside the function are valid. Argument types were not parsed as fully qualified types and the problem is corrected by making sure that fully qualified names are used when they are found in function arguments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Non-auto function arguments of custom types defined inside a namespace made the highlighter unable to check if member uses inside the function are valid. Argument types were not parsed as fully qualified types and the problem is corrected by making sure that fully qualified names are used when they are found in function arguments.
An example of a pattern that shows the error is id3.hexpat in the which uses unqualified types. In order to obtain the correct highlighting then you have to add the namespace to all custom types even if they are being used inside the namespace. Type names without namespace are considered by the syntax highlighting code as belonging to the global scope regardless of where the use takes place.