feat(taskview): move save button to action bar menu

Author: AKPWebDesign

app/src/main/java/tech/akpmakes/android/taskkeeper/TaskViewActivity.java

@@ -5,6 +5,9 @@
 import android.os.Bundle;
 import android.os.Handler;
 import android.support.v7.app.AppCompatActivity;
+import android.view.Menu;
+import android.view.MenuInflater;
+import android.view.MenuItem;
 import android.view.View;
 import android.widget.Button;
 import android.widget.CheckBox;
@@ -23,6 +26,7 @@
 
 public class TaskViewActivity extends AppCompatActivity implements DatePickerDialog.OnDateSetListener, TimePickerDialog.OnTimeSetListener {
     Calendar whenTime;
+    EditText taskName;
     TextView taskDate;
     TextView taskTime;
     CheckBox useCurrentTime;
@@ -32,11 +36,10 @@ public class TaskViewActivity extends AppCompatActivity implements DatePickerDia
     protected void onCreate(Bundle savedInstanceState) {
         super.onCreate(savedInstanceState);
         setContentView(R.layout.activity_task_view);
-        final EditText taskName = findViewById(R.id.task_name_content);
+        taskName = findViewById(R.id.task_name_content);
         taskDate = findViewById(R.id.task_when_date);
         taskTime = findViewById(R.id.task_when_time);
         useCurrentTime = findViewById(R.id.useCurrentTime);
-        Button taskSave = findViewById(R.id.btn_save_task);
 
         whenTime = Calendar.getInstance();
 
@@ -101,43 +104,47 @@ public void onClick(View view) {
                 timePicker.show(getFragmentManager(), "TimePickerDialog");
             }
         });
+    }
 
-        taskSave.setOnClickListener(new View.OnClickListener() {
-            @Override
-            public void onClick(View view) {
-                if(useCurrentTime.isChecked()) {
-                    updateTime();
-                }
-                String name = taskName.getText().toString();
-                Long when = whenTime.getTimeInMillis();
-                if (name.length() == 0) {
-                    taskName.setError("Task name is required!");
-                    return;
-                }
-                WhenEvent evt = new WhenEvent(name, when);
-                Intent i = new Intent();
-                i.putExtra("whenName", evt.getName());
-                i.putExtra("whenTime", evt.getWhen());
-                if(whenKey != null) {
-                    i.putExtra("whenKey", whenKey);
-                }
-                setResult(Activity.RESULT_OK, i);
-                finish();
-            }
-        });
-
-        useCurrentTime.setOnCheckedChangeListener(new CompoundButton.OnCheckedChangeListener() {
-            @Override
-            public void onCheckedChanged(CompoundButton compoundButton, boolean isChecked) {
-                if (isChecked) {
+    private void saveTask() {
+        if(useCurrentTime.isChecked()) {
+            updateTime();
+        }
+        String name = taskName.getText().toString();
+        Long when = whenTime.getTimeInMillis();
+        if (name.length() == 0) {
+            taskName.setError("Task name is required!");
+            return;
+        }
+        WhenEvent evt = new WhenEvent(name, when);
+        Intent i = new Intent();
+        i.putExtra("whenName", evt.getName());
+        i.putExtra("whenTime", evt.getWhen());
+        if(whenKey != null) {
+            i.putExtra("whenKey", whenKey);
+        }
+        setResult(Activity.RESULT_OK, i);
+        finish();
+    }
 
-                } else {
+    @Override
+    public boolean onCreateOptionsMenu(Menu menu) {
+        MenuInflater inflater = getMenuInflater();
+        inflater.inflate(R.menu.add_task_menu, menu);
+        return true;
+    }
 
-                }
-            }
-        });
+    @Override
+    public boolean onOptionsItemSelected(MenuItem item) {
+        switch (item.getItemId()) {
+            case R.id.save_task:
+                saveTask();
+            default:
+                return super.onOptionsItemSelected(item);
+        }
     }
 
+
     @Override
     public void onDateSet(DatePickerDialog view, int year, int monthOfYear, int dayOfMonth) {
         whenTime.set(Calendar.YEAR, year);
@@ -161,8 +168,7 @@ public void onTimeSet(TimePickerDialog view, int hourOfDay, int minute, int seco
     }
 
     private void updateTime() {
-        Calendar now = Calendar.getInstance();
-        whenTime = now;
+        whenTime = Calendar.getInstance();
         updateDateTimeUI();
     }
 

app/src/main/res/drawable/ic_save.xml

@@ -0,0 +1,9 @@
+<vector xmlns:android="http://schemas.android.com/apk/res/android"
+        android:width="24dp"
+        android:height="24dp"
+        android:viewportWidth="24.0"
+        android:viewportHeight="24.0">
+    <path
+        android:fillColor="#FFFFFFFF"
+        android:pathData="M17,3L5,3c-1.11,0 -2,0.9 -2,2v14c0,1.1 0.89,2 2,2h14c1.1,0 2,-0.9 2,-2L21,7l-4,-4zM12,19c-1.66,0 -3,-1.34 -3,-3s1.34,-3 3,-3 3,1.34 3,3 -1.34,3 -3,3zM15,9L5,9L5,5h10v4z"/>
+</vector>

app/src/main/res/menu/add_task_menu.xml

@@ -0,0 +1,9 @@
+<?xml version="1.0" encoding="utf-8"?>
+<menu xmlns:android="http://schemas.android.com/apk/res/android"
+    xmlns:app="http://schemas.android.com/apk/res-auto">
+    <item
+        android:id="@+id/save_task"
+        android:icon="@drawable/ic_save"
+        android:title="@string/save_task_label"
+        app:showAsAction="ifRoom" />
+</menu>