Conversation
…le paths, improve directory handling, introduce additional features, and refresh assets and app manifest.
There was a problem hiding this comment.
Pull request overview
This PR modernizes the Pengwin WSL distribution by enabling migration from the legacy "WLinux" name, improving the user experience when launching from different directories, and updating branding to reflect the current version and visual identity.
Changes:
- Added support for detecting and migrating from the old "WLinux" distribution name to "Pengwin"
- Improved launch behavior to use the current working directory when started outside of System32
- Updated branding (version to 26.2.1.0, background color to black) and Windows Terminal profile configuration
Reviewed changes
Copilot reviewed 7 out of 60 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
DistroLauncher/WslApiLoader.h |
Added old distribution name parameter and changed registration check to non-const |
DistroLauncher/WslApiLoader.cpp |
Implemented migration logic to check for both old and new distribution names |
DistroLauncher/DistroLauncher.cpp |
Added current directory detection for improved launch behavior and simplified user configuration |
DistroLauncher/DistributionInfo.h |
Updated distribution name constants and removed obsolete wsl.conf function |
DistroLauncher/DistributionInfo.cpp |
Changed user creation flag from --gecos to --comment |
Pengwin/Package.appxmanifest |
Updated version number and background color |
x64/pengwin.json |
Added new terminal profile and hid the old one |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
|
@copilot open a new pull request to apply changes based on the comments in this thread use spaces for identation |
|
@crramirez I've opened a new pull request, #815, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several key improvements and updates aimed at enhancing distribution registration, user experience, and branding for the Pengwin WSL distribution. The most significant changes include supporting migration from the old distribution name ("WLinux") to the new name ("Pengwin"), improving the launch behavior when started from different directories, updating branding elements, and refining user creation logic.
Distribution registration and migration:
WslApiLoaderclass and related logic to support both the new distribution name (Pengwin) and the old name (WLinux), allowing seamless migration for existing users. The loader now checks for registration under both names and updates the internal reference if the old name is found. (DistroLauncher/WslApiLoader.cpp,DistroLauncher/WslApiLoader.h,DistroLauncher/DistroLauncher.cpp,DistroLauncher/DistributionInfo.h) [1] [2] [3] [4] [5] [6]User experience improvements:
DistroLauncher/DistroLauncher.cpp) [1] [2]/etc/wsl.conf, simplifying the process and relying solely on the standard WSL APIs. (DistroLauncher/DistributionInfo.cpp,DistroLauncher/DistributionInfo.h,DistroLauncher/DistroLauncher.cpp) [1] [2] [3]Branding and manifest updates:
26.2.1.0), changed the background color to black, and ensured all references use the new "Pengwin" branding. (Pengwin/Package.appxmanifest) [1] [2]Terminal profile and settings updates:
showMarksOnScrollbar,autoMarkPrompts, and WSL-specific settings. (x64/pengwin.json) [1] [2]Miscellaneous improvements:
--commentflag instead of--gecosfor clarity and consistency. (DistroLauncher/DistributionInfo.cpp)