Skip to content

Remove forceloading#594

Open
Acuadragon100 wants to merge 2 commits intoWhoCraft:dev/1.20.1from
Acuadragon100:dev/1.20.1-remove-forceloading
Open

Remove forceloading#594
Acuadragon100 wants to merge 2 commits intoWhoCraft:dev/1.20.1from
Acuadragon100:dev/1.20.1-remove-forceloading

Conversation

@Acuadragon100
Copy link
Copy Markdown
Contributor

At the moment, the TARDIS turns forceloading on and then immediately off again when taking off or landing.

This means that if the chunk is forceloaded by some other mod/datapack, the TARDIS will remove that forceloading, which is not ideal. I tried removing it and could confirm that the mod does indeed continue working normally.

When I asked on Discord, there were 2 main reasons why forceloading was added.

  1. To fix TARDIS duplication. While I don't know all the sources of TARDIS duplication, the only one I was able to reproduce was the one where the server shuts down while the TARDIS is taking off. This would not be caused by the lack of forceloading, but rather by the fact that the TARDIS doesn't serialise ticksTakingOff, so it thinks it's already in flight when the server starts up again and thus never removes the exterior. Also, the new automatic de-duplication mechanic makes sure the duplicate automatically deletes itself anyway.
  2. To prevent the player from falling through Valkyrien Skies ships when exiting the TARDIS. As far as I understand it, ships don't actually load in when a chunk is forceloaded, but only when a player is nearby, which means forceloading won't make a difference. I'd also argue that the player falling through ships bug should be addressed upstream since it also affects other mods, and it should hopefully be (mostly) fixed now anyway.

Closes #551

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TARDIS removes forceloading when taking off/landing.

1 participant