Skip to content

fix: avoid double fixture load for clientvarcondition#233

Merged
WhyNotHugo merged 4 commits intoWhyNotHugo:mainfrom
npazosmendez:njpm/client-vat-fixes
May 20, 2025
Merged

fix: avoid double fixture load for clientvarcondition#233
WhyNotHugo merged 4 commits intoWhyNotHugo:mainfrom
npazosmendez:njpm/client-vat-fixes

Conversation

@npazosmendez
Copy link
Copy Markdown
Contributor

I noticed running python manage.py afipmetadata multiple times loaded the ClientVatCondition fixture multiple times. This fixes that using natural keys, just like GenericAfipType does.

Piggybacking two minor changes:

  • Add Spanish translations for ClientVatCondition strings
  • Remove the (code) string from ClientVatCondition's __str__, matching what GenericAfipType does

@WhyNotHugo
Copy link
Copy Markdown
Owner

CI failed due to running too frequently (El CEE ya posee un TA valido para el acceso al WSN solicitado !).

@WhyNotHugo WhyNotHugo merged commit 07d50b6 into WhyNotHugo:main May 20, 2025
5 of 7 checks passed
@WhyNotHugo
Copy link
Copy Markdown
Owner

All tests pass locally.

Applied, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants