Skip to content

v1.4.0#31

Merged
hwalker56 merged 22 commits intomasterfrom
dev
Mar 8, 2026
Merged

v1.4.0#31
hwalker56 merged 22 commits intomasterfrom
dev

Conversation

@hwalker56
Copy link
Member

@hwalker56 hwalker56 commented Mar 1, 2026

Changelog:

accidentally unpinned, closes #15
done through a QFileDialog(), i believe this should work fine in flatpak environments
closes #27, brings us closer to completing #24
* feat: flatpak support
* restructured to python module

* fix: data file placement for macos

* chore: fix indentation

* chore: run black

* fix(macos): set file path properly

* chore: check nuitka build
can be dealt with in guide, would break xdg portals
@hwalker56 hwalker56 added this to the Flatpak support milestone Mar 1, 2026
@DodoLeDev
Copy link

Hey! Some reviews after testing the flatpak package

Overall, the app works really well: I see the new page asking for a folder, and the folder is queried using XDG-portals, as expected!

Size of the WiiLink-GUI layer: 13Mo (99% is used by /app/lib/python3.13)


However, there is some quircks

  • The runtime version of the KDE platform is not up-to-date (there is a 6.10 version)
  • The app show the internal document store path, and not the real one, which may disappoint the user.
image
  • The entry shown above allows me to paste a path, but if I am using a Flatpak and provide a path that exists in the sandbox's tempfs, the app accepts it and continues.
    • In case the app is in a Flatpak, connect the click inside the text entry to the same action as the "Browse" button.
image
  • And finally, the most annoying issue, the app crashes when closed (a coredump is created):

Relevant log:

QThread: Destroyed while thread '' is still running

Coredump:

        Signal: 6 (ABRT)
  Command Line: /usr/bin/python /app/bin/WiiLinkPatcherGUI
    Executable: /usr/bin/python3.13
 Control Group: /user.slice/user-1000.slice/user@1000.service/app.slice/app-flatpak-ca.wiilink.Patcher-123456789.scope
          Unit: user@1000.service
     User Unit: app-flatpak-ca.wiilink.Patcher-123456789.scope
         Slice: user-1000.slice
       Message: Process 12345 (WiiLinkPatcherG) of user 1000 dumped core.
                
                Module /app/lib/libLLVM.so.21.1 without build-id.
                Module /app/lib/libLLVM.so.21.1
                Stack trace of thread 2:
                #0  0x00007fd4f4c9d51c n/a (/usr/lib/x86_64-linux-gnu/libc.so.6 + 0x9c51c)
                #1  0x00007fd4f4c433be n/a (/usr/lib/x86_64-linux-gnu/libc.so.6 + 0x423be)
                #2  0x00007fd4f4c2a8ed n/a (/usr/lib/x86_64-linux-gnu/libc.so.6 + 0x298ed)
                #3  0x00007fd4f32cc2b4 n/a (/usr/lib/x86_64-linux-gnu/libQt6Core.so.6.10.2 + 0xcc2b4)
                #4  0x00007fd4f3321efe n/a (/usr/lib/x86_64-linux-gnu/libQt6Core.so.6.10.2 + 0x121efe)
                #5  0x00007fd4f32cd8c6 n/a (/usr/lib/x86_64-linux-gnu/libQt6Core.so.6.10.2 + 0xcd8c6)
                #6  0x00007fd4f32e99f1 n/a (/usr/lib/x86_64-linux-gnu/libQt6Core.so.6.10.2 + 0xe99f1)
                #7  0x00007fd4f3b43316 n/a (/app/lib/python3.13/site-packages/PySide6/QtCore.abi3.so + 0x143316)
                #8  0x00007fd4f3ed4d7e n/a (/app/lib/python3.13/site-packages/PySide6/libpyside6.abi3.so.6.10 + 0x17d7e)
                #9  0x00007fd4f447e8e5 n/a (/app/lib/python3.13/site-packages/shiboken6/libshiboken6.abi3.so.6.10 + 0x2b8e5)
                #10 0x00007fd4f3ed4abd n/a (/app/lib/python3.13/site-packages/PySide6/libpyside6.abi3.so.6.10 + 0x17abd)
                #11 0x00007fd4f3edb5d5 n/a (/app/lib/python3.13/site-packages/PySide6/libpyside6.abi3.so.6.10 + 0x1e5d5)
                #12 0x00007fd4f3adf7fc n/a (/app/lib/python3.13/site-packages/PySide6/QtCore.abi3.so + 0xdf7fc)
                #13 0x00007fd4f4f37a04 n/a (/usr/lib/x86_64-linux-gnu/libpython3.13.so.1.0 + 0x137a04)
                #14 0x00007fd4f4f940d2 n/a (/usr/lib/x86_64-linux-gnu/libpython3.13.so.1.0 + 0x1940d2)
                #15 0x00007fd4f50dff46 n/a (/usr/lib/x86_64-linux-gnu/libpython3.13.so.1.0 + 0x2dff46)
                #16 0x00007fd4f50e090d n/a (/usr/lib/x86_64-linux-gnu/libpython3.13.so.1.0 + 0x2e090d)
                #17 0x00007fd4f50e0b1b n/a (/usr/lib/x86_64-linux-gnu/libpython3.13.so.1.0 + 0x2e0b1b)
                #18 0x00007fd4f516d779 n/a (/usr/lib/x86_64-linux-gnu/libpython3.13.so.1.0 + 0x36d779)
                #19 0x00007fd4f516efd4 n/a (/usr/lib/x86_64-linux-gnu/libpython3.13.so.1.0 + 0x36efd4)
                #20 0x00007fd4f4c2c975 n/a (/usr/lib/x86_64-linux-gnu/libc.so.6 + 0x2b975)
                #21 0x00007fd4f4c2ca28 n/a (/usr/lib/x86_64-linux-gnu/libc.so.6 + 0x2ba28)
                #22 0x00005616b2f0c095 n/a (/usr/bin/python3.13 + 0x1095)
                ELF object binary architecture: AMD x86-64

resolves crash on exit
also disables manually entering a path, this can be done through the QFileDialog window anyway
@hwalker56
Copy link
Member Author

Hi, thanks for this comment @DodoLeDev.

I have resolved the crash on exit (which has admittedly been there for a while), and changed the app to display the real path when running in a Flatpak.

As for the runtime version being "outdated" at version 6.9, this is intended as the app is built against, and tested with, Qt 6.9, as this version is the latest version to support a reasonable amount of macOS versions. If this causes issues with Flathub I will change it, but I'd like to keep things consistent across all platforms.

@hwalker56 hwalker56 merged commit e9a4ee8 into master Mar 8, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants