SLOP-45: Fix PHP 8 compatibility and undefined array keys in RemoteWiki#10
Open
SLOP-45: Fix PHP 8 compatibility and undefined array keys in RemoteWiki#10
Conversation
- validateEndpoint: accept ?string so null endpoint (e.g. {{#remote_version:}}) does not cause TypeError
- getWikiApi: use ?? '' for parse_url host/path to avoid undefined array key when URL has no path
- getGenerator: use ?? '' when reading result['query']['general']['generator']
- getExtensionsData: use ?? [] when reading result['query']['extensions']
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes TypeError when no endpoint is passed and undefined array key notices in PHP 8.
Jira: SLOP-45
Steps to reproduce:
{{#remote_version:}}— previously: validateEndpoint(string) received null → TypeError (PHP 8).Expected: No TypeError; no undefined array key notices; empty string or safe fallback when endpoint is missing or API structure differs.
Changes: