Guard against null getTitle(); send same comment body to each Jira issue#9
Open
Guard against null getTitle(); send same comment body to each Jira issue#9
Conversation
- onPageSaveComplete: check wikiPage->getTitle() and return early if null to avoid fatal in getFullText() or inside getDiffLink() - getDiffLink: null-check getTitle() and return '' when null (defensive) - Fix comment body: build commentBody once and send that same string to each issue key instead of accumulating and sending a growing string to each Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes in
PageSaveCompletehook handler:Null getTitle():
WikiPage::getTitle()can return null in edge cases. We now check and return early inonPageSaveComplete, and defensively ingetDiffLink()return''when title is null, avoiding a fatal when callinggetFullText()orgetFullURL().Comment body per issue: The loop previously accumulated the comment string and sent that growing string to each Jira issue (first issue got one block, second got two blocks, etc.). The comment body is now built once and the same body is sent to each issue key.
Changes
$wikiPage->getTitle()is null; build$commentBodyonce and pass it to eachsendToJira()call; ingetDiffLink()null-check title and return''when null.Testing
php -l src/Hooks.phppasses.Jira: create SLOP task(s) and add comment (summary, PR link, scores, humorous paragraph, "Work was performed by AI / Cursor Agent").
Work performed by AI / Cursor Agent.