Validate install.sh inputs to prevent PHP injection in LocalSettings.php#12
Open
Validate install.sh inputs to prevent PHP injection in LocalSettings.php#12
Conversation
- extension: allow only [a-zA-Z0-9_-], reject empty - type: allow only 'extension' or 'skin' - extra_file: if set, allow only [a-zA-Z0-9_./-] and reject '..' Prevents malicious workflow inputs from injecting PHP into generated LocalSettings.php (e.g. extension="'; phpinfo(); //"). Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
install.shwrites user-controlled action inputs (extension,type,extra_file) intoLocalSettings.phpwithout validation. A workflow (e.g. a PR) could pass e.g.extension: "'; phpinfo(); //"and execute arbitrary PHP in CI.Fix: Validate before use:
[a-zA-Z0-9_-]extensionorskin[a-zA-Z0-9_./-], reject..Testing
install.shwith malicious extension name → exit 1, error message.mediawiki/when not in CI, as expected).Jira + GitHub issue to be created when Jira is available. Work was performed by AI / Cursor Agent.