-
Notifications
You must be signed in to change notification settings - Fork 85
enable mw api emailuser backend #1498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jsnshrmn
wants to merge
13
commits into
master
Choose a base branch
from
Jsn.sherman/T412427
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
b660853
emails: add mediawiki api backend
jsnshrmn aecdf56
users: add survey email to admin as non-editable
jsnshrmn f228e59
user survey email cmd: exclude blank email
jsnshrmn b874814
emails: custom model manager + cleanup_email cmd
jsnshrmn d233bed
user survey email cmd: use mw email backend
jsnshrmn 2d9e2bc
user survey email cmd: 1 session per batch
jsnshrmn f351494
user survey email cmd: track emails in djmail
jsnshrmn 371f24a
emails: swap survey backend to default for tests
katydidnot 861f126
user survey email cmd bugfixes
jsnshrmn cbeb003
conf: add MW_API_URL var for staging & prod
jsnshrmn 910475f
user survey email cmd improvements
jsnshrmn 44b83b5
emails.backends.mediawiki: set user-agent
jsnshrmn 3c1a3ac
emails.backends.mediawiki: improve error handling
jsnshrmn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,289 @@ | ||
| """ | ||
| Email backend that POSTs messages to the MediaWiki Emailuser endpoint. | ||
| see: https://www.mediawiki.org/wiki/API:Emailuser | ||
| """ | ||
| import logging | ||
| from json import dumps | ||
| from requests import Session | ||
| from requests.exceptions import ConnectionError | ||
| from requests.structures import CaseInsensitiveDict | ||
| from time import sleep | ||
|
|
||
| from django.conf import settings | ||
| from django.core.mail.backends.base import BaseEmailBackend | ||
|
|
||
| from TWLight.users.models import Editor | ||
|
|
||
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| def retry_conn(): | ||
| """A decorator that handles connection retries.""" | ||
| retry_delay = 0 | ||
| retry_on_connection_error = 10 | ||
| retry_after_conn = 5 | ||
|
|
||
| def wrapper(func): | ||
| def conn(*args, **kwargs): | ||
| try_count = 0 | ||
| try_count_conn = 0 | ||
| while True: | ||
| try_count += 1 | ||
| try_count_conn += 1 | ||
|
|
||
| if retry_delay: | ||
| sleep(retry_delay) | ||
| try: | ||
| return func(*args, **kwargs) | ||
| except ConnectionError as e: | ||
| no_retry_conn = 0 <= retry_on_connection_error < try_count_conn | ||
| if no_retry_conn: | ||
| logger.warning("ConnectionError exhausted retries") | ||
| raise e | ||
| logger.warning( | ||
| "ConnectionError, retrying in {}s".format(retry_after_conn) | ||
| ) | ||
| sleep(retry_after_conn) | ||
| continue | ||
|
|
||
| return conn | ||
|
|
||
| return wrapper | ||
|
|
||
|
|
||
| class EmailBackend(BaseEmailBackend): | ||
| def __init__( | ||
| self, | ||
| url=None, | ||
| timeout=None, | ||
| delay=None, | ||
| retry_delay=None, | ||
| maxlag=None, | ||
| username=None, | ||
| password=None, | ||
| fail_silently=False, | ||
| **kwargs, | ||
| ): | ||
| super().__init__(fail_silently=fail_silently) | ||
| self.url = settings.MW_API_URL if url is None else url | ||
| self.headers = CaseInsensitiveDict() | ||
| self.headers["User-Agent"] = "{}/0.0.1".format(__name__) | ||
| self.url = settings.MW_API_URL if url is None else url | ||
| self.timeout = settings.MW_API_REQUEST_TIMEOUT if timeout is None else timeout | ||
| self.delay = settings.MW_API_REQUEST_DELAY if delay is None else delay | ||
| self.retry_delay = ( | ||
| settings.MW_API_REQUEST_RETRY_DELAY if retry_delay is None else retry_delay | ||
| ) | ||
| self.maxlag = settings.MW_API_MAXLAG if maxlag is None else maxlag | ||
| self.username = settings.MW_API_EMAIL_USER if username is None else username | ||
| self.password = settings.MW_API_EMAIL_PASSWORD if password is None else password | ||
| self.email_token = None | ||
| self.session = None | ||
| logger.info("Email connection constructed.") | ||
|
|
||
| def _handle_request(self, response, try_count=0): | ||
| """ | ||
| A helper method that handles MW API responses | ||
| including maxlag retries. | ||
| """ | ||
| # Raise for any HTTP response errors | ||
| if response.status_code != 200: | ||
| raise Exception("HTTP {} error".format(response.status_code)) | ||
| data = response.json() | ||
| error = data.get("error", {}) | ||
| if "warnings" in data: | ||
| logger.warning(dumps(data["warnings"], indent=True)) | ||
| # raise for any api error codes besides max lag | ||
| try: | ||
| if error.get("code") != "maxlag": | ||
| raise Exception(dumps(error)) | ||
| except: | ||
| # return data if there are no errors | ||
| return data | ||
|
|
||
| # handle retries with max lag | ||
| lag = error.get("lag") | ||
| request = response.request | ||
| retry_after = float(response.headers.get("Retry-After", 5)) | ||
| retry_on_lag_error = 50 | ||
| no_retry = 0 <= retry_on_lag_error < try_count | ||
| message = "Server exceeded maxlag" | ||
| if not no_retry: | ||
| message += ", retrying in {}s".format(retry_after) | ||
| if lag: | ||
| message += ", lag={}".format(lag) | ||
| message += ", url={}".format(self.url) | ||
| log = logger.warning if no_retry else logger.info | ||
| log( | ||
| message, | ||
| { | ||
| "code": "maxlag-retry", | ||
| "retry-after": retry_after, | ||
| "lag": lag, | ||
| "x-database-lag": response.headers.get("X-Database-Lag", 5), | ||
| }, | ||
| ) | ||
| if no_retry: | ||
| raise Exception(message) | ||
|
|
||
| sleep(retry_after) | ||
| try_count += 1 | ||
| return self._handle_request(self.session.send(request), try_count) | ||
|
|
||
| @retry_conn() | ||
| def open(self): | ||
| """ | ||
| Ensure an open session to the API server. Return whether or not a | ||
| new session was required (True or False) or None if an exception | ||
| passed silently. | ||
| """ | ||
| if self.session: | ||
| # Nothing to do if the session exists | ||
| return False | ||
|
|
||
| try: | ||
| self.session = Session() | ||
| self.session.headers = self.headers | ||
| logger.info("Session created, getting login token...") | ||
|
|
||
| # GET request to fetch login token | ||
| login_token_params = { | ||
| "action": "query", | ||
| "meta": "tokens", | ||
| "type": "login", | ||
| "maxlag": self.maxlag, | ||
| "format": "json", | ||
| } | ||
| login_token_response = self._handle_request( | ||
| self.session.get(url=self.url, params=login_token_params) | ||
| ) | ||
| login_token = login_token_response["query"]["tokens"]["logintoken"] | ||
| if not login_token: | ||
| self.session = None | ||
| raise Exception(dumps(login_token_response)) | ||
|
|
||
| # POST request to log in. Use of main account for login is not | ||
| # supported. Obtain credentials via Special:BotPasswords | ||
| # (https://www.mediawiki.org/wiki/Special:BotPasswords) for lgname & lgpassword | ||
| login_params = { | ||
| "action": "login", | ||
| "lgname": self.username, | ||
| "lgpassword": self.password, | ||
| "lgtoken": login_token, | ||
| "maxlag": self.maxlag, | ||
| "format": "json", | ||
| } | ||
| logger.info("Signing in...") | ||
| login_response = self._handle_request( | ||
| self.session.post(url=self.url, data=login_params) | ||
| ) | ||
|
|
||
| # GET request to fetch Email token | ||
| # see: https://www.mediawiki.org/wiki/API:Emailuser#Token | ||
| email_token_params = {"action": "query", "meta": "tokens", "format": "json"} | ||
|
|
||
| logger.info("Getting email token...") | ||
| email_token_response = self._handle_request( | ||
| self.session.get(url=self.url, params=email_token_params) | ||
| ) | ||
| email_token = email_token_response["query"]["tokens"]["csrftoken"] | ||
| if not email_token: | ||
| self.session = None | ||
| raise Exception(dumps(email_token_response)) | ||
|
|
||
| # Assign the email token | ||
| self.email_token = email_token | ||
| logger.info("Email API session ready.") | ||
| return True | ||
| except: | ||
| if not self.fail_silently: | ||
| raise | ||
|
|
||
| def close(self): | ||
| """Unset the session.""" | ||
| self.email_token = None | ||
| self.session = None | ||
| logger.info("Session destroyed.") | ||
|
|
||
| def send_messages(self, email_messages): | ||
| """ | ||
| Send one or more EmailMessage objects and return the number of email | ||
| messages sent. | ||
| """ | ||
| if not email_messages: | ||
| return 0 | ||
| new_session_created = self.open() | ||
| if not self.session or new_session_created is None: | ||
| # We failed silently on open(). | ||
| # Trying to send would be pointless. | ||
| return 0 | ||
| num_sent = 0 | ||
| for message in email_messages: | ||
| sent = self._send(message) | ||
| if sent: | ||
| num_sent += 1 | ||
| if new_session_created: | ||
| self.close() | ||
| return num_sent | ||
|
|
||
| @retry_conn() | ||
| def _send(self, email_message): | ||
| """A helper method that does the actual sending.""" | ||
| if not email_message.recipients(): | ||
| return False | ||
|
|
||
| try: | ||
| for recipient in email_message.recipients(): | ||
| # lookup the target editor from the email address | ||
| target_qs = Editor.objects.filter(user__email=recipient).values_list( | ||
| "wp_username", flat=True | ||
| ) | ||
| target_qs_count = target_qs.count() | ||
| if target_qs_count > 1: | ||
| raise Exception( | ||
| "skip shared email address: {}".format(list(target_qs)) | ||
| ) | ||
|
|
||
| target = target_qs.first() | ||
|
|
||
| # GET request to check if user is emailable | ||
| emailable_params = { | ||
| "action": "query", | ||
| "list": "users", | ||
| "ususers": target, | ||
| "usprop": "emailable", | ||
| "maxlag": self.maxlag, | ||
| "format": "json", | ||
| } | ||
|
|
||
| emailable_response = self._handle_request( | ||
| self.session.post(url=self.url, data=emailable_params) | ||
| ) | ||
| emailable = "emailable" in emailable_response["query"]["users"][0] | ||
| if not emailable: | ||
| raise Exception("skip not emailable: {}".format(target)) | ||
|
|
||
| # POST request to send an email | ||
| email_params = { | ||
| "action": "emailuser", | ||
| "target": target, | ||
| "subject": email_message.subject, | ||
| "text": email_message.body, | ||
| "token": self.email_token, | ||
| "maxlag": self.maxlag, | ||
| "format": "json", | ||
| } | ||
|
|
||
| logger.info("Sending email...") | ||
| emailuser_response = self._handle_request( | ||
| self.session.post(url=self.url, data=email_params) | ||
| ) | ||
| if emailuser_response["emailuser"]["result"] != "Success": | ||
| raise Exception(dumps(emailuser_response)) | ||
|
|
||
| logger.info("Email sent.") | ||
| except: | ||
| if not self.fail_silently: | ||
| raise | ||
| return False | ||
| return True | ||
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| # -*- coding: utf-8 -*- | ||
| from django.core.management.base import BaseCommand | ||
|
|
||
| from TWLight.emails.models import Message | ||
|
|
||
|
|
||
| class Command(BaseCommand): | ||
jsnshrmn marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| help = "Delete unsent emails." | ||
|
|
||
| def add_arguments(self, parser): | ||
| parser.add_argument( | ||
| "--subject", | ||
| type=str, | ||
| required=False, | ||
| help="Email subject", | ||
| ) | ||
|
|
||
| def handle(self, *args, **options): | ||
| subject = options["subject"] | ||
|
|
||
| if subject is None: | ||
| Message.twl.unsent().delete() | ||
| else: | ||
| Message.twl.filter(subject=subject).unsent().delete() | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| # -*- coding: utf-8 -*- | ||
| from django.conf import settings | ||
| from django.contrib.auth.models import User | ||
| from django.db import models | ||
| from django.utils.translation import gettext as _, override | ||
|
|
||
| from djmail.models import Message | ||
|
|
||
| from TWLight.users.models import UserProfile | ||
|
|
||
|
|
||
| class MessageQuerySet(models.QuerySet): | ||
| def unsent(self): | ||
| return self.exclude(status=Message.STATUS_SENT) | ||
|
|
||
| def users_with_unsent(self): | ||
| email_addresses = self.unsent().values_list("to_email", flat=True) | ||
| return User.objects.filter(email__in=email_addresses) | ||
|
|
||
| def userprofiles_with_unsent(self): | ||
| email_addresses = self.unsent().values_list("to_email", flat=True) | ||
| return UserProfile.objects.select_related("user").filter( | ||
| user__email__in=email_addresses | ||
| ) | ||
|
|
||
| def user_pks_with_subject_list(self, subject, users): | ||
| if users is None: | ||
| return [] | ||
|
|
||
| subjects = [] | ||
| # Get the localized subject for each available language | ||
| for lang_code, _lang_name in settings.LANGUAGES: | ||
| try: | ||
| with override(lang_code): | ||
| # Translators: do not translate | ||
| subjects.append(_(subject)) | ||
| except ValueError: | ||
| pass | ||
|
|
||
| # Search for repients of sent messages with the one of the localized email subjects. | ||
| previous_recipients = self.filter( | ||
| status=Message.STATUS_SENT, | ||
| subject__in=subjects, | ||
| ).values_list("to_email", flat=True) | ||
|
|
||
| # return a list of pks for users with matching email addresses | ||
| return users.filter(email__in=previous_recipients).values_list("pk", flat=True) | ||
|
|
||
|
|
||
| class MessageManager(models.Manager): | ||
| def get_queryset(self): | ||
| return MessageQuerySet(self.model, using=self._db) | ||
|
|
||
| def unsent(self): | ||
| return self.get_queryset().unsent() | ||
|
|
||
| def userprofiles_with_unsent(self): | ||
| return self.get_queryset().userprofiles_with_unsent() | ||
|
|
||
| def user_pks_with_subject_list(self, subject, users): | ||
| return self.get_queryset().user_pks_with_subject_list( | ||
| subject=subject, users=users | ||
| ) | ||
|
|
||
|
|
||
| # add "twl" manager to Message | ||
| Message.add_to_class("twl", MessageManager()) |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.