Skip to content
This repository was archived by the owner on Feb 28, 2026. It is now read-only.

Feature/marketing#83

Merged
YDrogen merged 5 commits intodevelopfrom
feature/marketing
Jun 17, 2025
Merged

Feature/marketing#83
YDrogen merged 5 commits intodevelopfrom
feature/marketing

Conversation

@taketomi001
Copy link
Contributor

@taketomi001 taketomi001 commented Jun 16, 2025

Description

Please include a summary of the change or which issue is fixed.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Area of change

  • Frontend
  • Backend
  • Other: .....

General checklist:

  • My code follows the style guidelines of this project
  • I ran npm run format/npm run lint before commit
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation where needed
  • My changes generate no new warnings
  • I have checked my code and corrected any misspellings
  • I have updated develop and merged to my branch before submitting pull request
  • My pull request generate no conflicts with develop branch
  • I requested code review from other team members

Frontend checklist:

  • I followed guidelines for HTML/JSX/Typescript
  • My Javascript generate no new console errors
  • I tested my code cross browsers
  • My slice is pixel perfect for both desktop and mobile according to design
  • I conducted basic QA to assure all features are working
  • I tested responsive for mobile and tablet resolutions

Backend checklist:

  • I tested admin by manually adding content from zero
  • I created easy to use admin experience which is self-explanatory
  • I added description to admin fields in hard-to-understand areas
  • I followed guidelines for naming Typescript variables
  • I conducted basic QA to assure all features are working

ticoq971
ticoq971 previously approved these changes Jun 17, 2025
@taketomi001 taketomi001 dismissed ticoq971’s stale review June 17, 2025 07:49

The merge-base changed after approval.

@YDrogen YDrogen removed the Sylvain label Jun 17, 2025
ticoq971
ticoq971 previously approved these changes Jun 17, 2025
@taketomi001 taketomi001 dismissed ticoq971’s stale review June 17, 2025 07:59

The merge-base changed after approval.

YDrogen
YDrogen previously approved these changes Jun 17, 2025
@taketomi001 taketomi001 dismissed YDrogen’s stale review June 17, 2025 09:02

The merge-base changed after approval.

@YDrogen YDrogen merged commit ee251ce into develop Jun 17, 2025
1 check passed
@YDrogen YDrogen deleted the feature/marketing branch June 17, 2025 09:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants