Add loading status to site settings data related dropdown#1446
Open
Add loading status to site settings data related dropdown#1446
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1446 +/- ##
==========================================
- Coverage 47.21% 46.91% -0.30%
==========================================
Files 272 274 +2
Lines 9720 9783 +63
Branches 2862 2895 +33
==========================================
+ Hits 4589 4590 +1
- Misses 4900 4959 +59
- Partials 231 234 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Do we know why the site-settings response is slow? Can we address that as well? |
Contributor
Author
it might be related to both frontend and backend. in another branch I have some updates on reducing calls of site-settings, once that got merged, I'll updated related pages to use context provider instead of making new calls every page |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in some environments, the site-settings response can be slow, causing certain dropdowns to briefly render with empty options. this PR adds loading spinners to the affected selects on the Encounter and Search Encounter pages to clearly indicate the options are still loading and avoid confusion
PR fixes #1443