Another iteration of build and deploy of native MinGW toolchain with itself#19
Open
Another iteration of build and deploy of native MinGW toolchain with itself#19
Conversation
0b6fd02 to
a88b5f4
Compare
fb9ffe4 to
a919a77
Compare
1a70d1b to
fc662a5
Compare
a919a77 to
df3e2be
Compare
0ff5777 to
f180c17
Compare
f180c17 to
550a184
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR iterates the native MinGW toolchain build and deploy workflows by introducing new package jobs and updating the build-package workflow. The changes include adding several new jobs in the mingw-native-toolchain workflow to build additional packages, modifying job dependencies with updated "needs" values, and adding a new input to conditionally skip job steps in the build-package workflow.
Reviewed Changes
Copilot reviewed 2 out of 7 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/mingw-native-toolchain.yml | Added new package build jobs and updated dependency chains. |
| .github/workflows/build-package.yml | Introduced a new boolean input "if" to conditionally run steps and updated several step conditions accordingly. |
Files not reviewed (5)
- .github/scripts/download-artifacts.sh: Language not supported
- .github/scripts/install-artifacts.sh: Language not supported
- .github/scripts/pthread-headers-hack-after.sh: Language not supported
- .github/scripts/pthread-headers-hack-before.sh: Language not supported
- build-native-with-native.sh: Language not supported
Comments suppressed due to low confidence (2)
.github/workflows/build-package.yml:6
- [nitpick] The input named 'if' is ambiguous since 'if' is a reserved keyword in workflow expressions; consider renaming it to a more descriptive term like 'should_run' to improve clarity.
if:
.github/workflows/mingw-native-toolchain.yml:130
- [nitpick] Passing 'needs' as an input to the called workflow can be confusing given the reserved use of 'needs' in GitHub workflows; consider renaming this input to something like 'dependency_jobs' for clarity.
needs: ${{ toJson(needs) }}
Blackhex
commented
Apr 10, 2025
| .github/scripts/install-dependencies.sh | ||
| .github/scripts/enable-ccache.sh | ||
|
|
||
| build_package mingw-w64-libtool |
Member
Author
There was a problem hiding this comment.
TODO: Share logic with build-native-with-cross.sh upon #10 (comment)
fc662a5 to
5bcad95
Compare
550a184 to
5181a69
Compare
…ss-mingwarm64-crt`
5181a69 to
4cecf4c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the secod iteration of the native toolchain build the following packages can be build with the toolchain from the previous iteration first and then replace their x64 variants for the second iteration toolchain build:
mingw-w64-libtoolmingw-w64-ninjamingw-w64-pkgconfmingw-w64-autotoolsmingw-w64-gperfAlso, the following utility packages that are part of MinGW codebse can be built afterwards:
mingw-w64-libmangle-gitmingw-w64-tools-gitVerified by https://github.com/Windows-on-ARM-Experiments/msys2-woarm64-build/actions/runs/14217604079.