Skip to content

Another iteration of build and deploy of native MinGW toolchain with itself#19

Open
Blackhex wants to merge 2 commits intomainfrom
native-mingw-toolchain-2
Open

Another iteration of build and deploy of native MinGW toolchain with itself#19
Blackhex wants to merge 2 commits intomainfrom
native-mingw-toolchain-2

Conversation

@Blackhex
Copy link
Copy Markdown
Member

@Blackhex Blackhex commented Mar 19, 2025

In the secod iteration of the native toolchain build the following packages can be build with the toolchain from the previous iteration first and then replace their x64 variants for the second iteration toolchain build:

  • mingw-w64-libtool
  • mingw-w64-ninja
  • mingw-w64-pkgconf
  • mingw-w64-autotools
  • mingw-w64-gperf

Also, the following utility packages that are part of MinGW codebse can be built afterwards:

  • mingw-w64-libmangle-git
  • mingw-w64-tools-git

Verified by https://github.com/Windows-on-ARM-Experiments/msys2-woarm64-build/actions/runs/14217604079.

@Blackhex Blackhex marked this pull request as draft March 19, 2025 08:27
@Blackhex Blackhex force-pushed the native-mingw-toolchain-2 branch 4 times, most recently from 0b6fd02 to a88b5f4 Compare March 20, 2025 09:11
@Blackhex Blackhex force-pushed the native-mingw-toolchain-2 branch 11 times, most recently from fb9ffe4 to a919a77 Compare March 21, 2025 07:46
@Blackhex Blackhex force-pushed the native-mingw-toolchain branch from 1a70d1b to fc662a5 Compare March 21, 2025 14:33
@Blackhex Blackhex force-pushed the native-mingw-toolchain-2 branch from a919a77 to df3e2be Compare March 24, 2025 09:39
@Blackhex Blackhex force-pushed the native-mingw-toolchain-2 branch from 0ff5777 to f180c17 Compare April 2, 2025 10:38
@Blackhex Blackhex self-assigned this Apr 2, 2025
@Blackhex Blackhex force-pushed the native-mingw-toolchain-2 branch from f180c17 to 550a184 Compare April 3, 2025 07:24
@Blackhex Blackhex requested a review from Copilot April 3, 2025 07:25
@Blackhex Blackhex marked this pull request as ready for review April 3, 2025 07:25
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR iterates the native MinGW toolchain build and deploy workflows by introducing new package jobs and updating the build-package workflow. The changes include adding several new jobs in the mingw-native-toolchain workflow to build additional packages, modifying job dependencies with updated "needs" values, and adding a new input to conditionally skip job steps in the build-package workflow.

Reviewed Changes

Copilot reviewed 2 out of 7 changed files in this pull request and generated no comments.

File Description
.github/workflows/mingw-native-toolchain.yml Added new package build jobs and updated dependency chains.
.github/workflows/build-package.yml Introduced a new boolean input "if" to conditionally run steps and updated several step conditions accordingly.
Files not reviewed (5)
  • .github/scripts/download-artifacts.sh: Language not supported
  • .github/scripts/install-artifacts.sh: Language not supported
  • .github/scripts/pthread-headers-hack-after.sh: Language not supported
  • .github/scripts/pthread-headers-hack-before.sh: Language not supported
  • build-native-with-native.sh: Language not supported
Comments suppressed due to low confidence (2)

.github/workflows/build-package.yml:6

  • [nitpick] The input named 'if' is ambiguous since 'if' is a reserved keyword in workflow expressions; consider renaming it to a more descriptive term like 'should_run' to improve clarity.
if:

.github/workflows/mingw-native-toolchain.yml:130

  • [nitpick] Passing 'needs' as an input to the called workflow can be confusing given the reserved use of 'needs' in GitHub workflows; consider renaming this input to something like 'dependency_jobs' for clarity.
needs: ${{ toJson(needs) }}

@Blackhex Blackhex requested a review from eukarpov April 3, 2025 07:29
.github/scripts/install-dependencies.sh
.github/scripts/enable-ccache.sh

build_package mingw-w64-libtool
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Share logic with build-native-with-cross.sh upon #10 (comment)

@Blackhex Blackhex force-pushed the native-mingw-toolchain branch from fc662a5 to 5bcad95 Compare April 11, 2025 06:45
Base automatically changed from native-mingw-toolchain to main April 11, 2025 06:47
@Blackhex Blackhex force-pushed the native-mingw-toolchain-2 branch from 550a184 to 5181a69 Compare April 11, 2025 06:49
@Blackhex Blackhex force-pushed the native-mingw-toolchain-2 branch from 5181a69 to 4cecf4c Compare April 28, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants