Avoid corruption of W_PROGRAMS_WIN and W_PROGRAMS_X86_WIN when running from syswow64#2453
Open
SurenIV wants to merge 1 commit intoWinetricks:masterfrom
Open
Avoid corruption of W_PROGRAMS_WIN and W_PROGRAMS_X86_WIN when running from syswow64#2453SurenIV wants to merge 1 commit intoWinetricks:masterfrom
SurenIV wants to merge 1 commit intoWinetricks:masterfrom
Conversation
src/winetricks
Outdated
| } | ||
|
|
||
| # Expand an environment variable and print it to stdout | ||
| # Move to $WINEPREFIX to avoid corruption of W_PROGRAMS_WIN and W_PROGRAMS_X86_WIN when running from syswo64 |
Contributor
There was a problem hiding this comment.
Suggested change
| # Move to $WINEPREFIX to avoid corruption of W_PROGRAMS_WIN and W_PROGRAMS_X86_WIN when running from syswo64 | |
| # Move to $WINEPREFIX to avoid corruption of W_PROGRAMS_WIN and W_PROGRAMS_X86_WIN when running from syswow64 |
SurenIV
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The corruption occurs in the 64bit prefix when the component installation is run in the syswow64 directory:
++ w_pathconv -u 'C:\Program Files (x86)'
++ case "${W_PLATFORM}" in
++ case "$@" in
++ winetricks_wintounix 'C:\Program Files (x86)'
++ W_winp='C:\Program Files (x86)'
++ _W_winp='\Program Files (x86)'
++ printf %s /home/guest/.wine/dosdevices/c:
++ echo '\Program Files (x86)'
++ sed 's,\,/,g'
...
To avoid this, I added cd to the root of the prefix.