Skip to content

Add comment in winetricks_selfupdate and winetricks_selfupdate_rollback warning of race condition #2489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GideonBear wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −0
Open

Add comment in winetricks_selfupdate and winetricks_selfupdate_rollback warning of race condition #2489

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/winetricks
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1456,6 +1456,7 @@ winetricks_selfupdate()
w_try cp "$0" "${_W_rollback_file}"
w_try chmod -x "${_W_rollback_file}"

# Uses mv to avoid race condition in overwriting running shell script. Do not replace with cp or other non-atomic writes!
w_try mv "${_W_update_file}" "$0"
w_try chmod +x "$0"

Expand All @@ -1471,6 +1472,7 @@ winetricks_selfupdate_rollback()
_W_rollback_file="${0}.bak"

if test -f "${_W_rollback_file}"; then
# Uses mv to avoid race condition in overwriting running shell script. Do not replace with cp or other non-atomic writes!
w_try mv "${_W_rollback_file}" "$0"
w_try chmod +x "$0"
w_warn "Rollback finished! The current version is $($0 -V)."
Expand Down