Open
Conversation
Member
|
This sounds good; “main” is a horrifically overloaded and thus confusing name. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proposal for a new
import.meta.commandkey on import meta, exactly matching the definition ofimport.meta.main. NodeJS has had difficulty finding alignment onimport.meta.main(see nodejs/node#49440), primarily because of a lack of clarify as to what exactly it means.The name
commandis used here to indicate that this is the module that defines the POSIX-style command behaviour. The description has been further clarified to note that this is specifically only set for a process execution as well as for the top-level execution context in that process - workers, custom realms, other loader registries pointing to the same URL etc etc are therefore excluded from matching this condition (where perhaps a directprocess.argv[1]equality might.This PR is created in conjunction with the Node.js PR to introduce the behaviour.