Error and promise rejection events must be fired on the global object #82
+11
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As decided in today's meeting, this PR specifies that the `error`, `unhandledrejection` and `rejectionhandled` events are fired on the global object. It also adds the `ErrorEvent` and `PromiseRejectionEvent` interfaces, and the `onerror`, `onunhandledrejection` and `onrejectionhandled` event handler properties, to the minimum common API list. This PR also has a note covering the likely case that Node.js will not support this due to legacy.
jasnell
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As decided in today's meeting, this PR specifies that the
error,unhandledrejectionandrejectionhandledevents are fired on the global object. It also adds theErrorEventandPromiseRejectionEventinterfaces, and theonerror,onunhandledrejectionandonrejectionhandledevent handler properties, to the minimum common API list.This PR also has a note covering the likely case that Node.js will not support this due to legacy.