Skip to content

Remove explicit useMemo (React Compiler handles it) #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Wintus wants to merge 2 commits into from
Closed

Remove explicit useMemo (React Compiler handles it) #150

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff26bc2
refactor: remove explicit useMemo in PageTitleInput
Wintus Jan 16, 2026
c725e8f
refactor: convert pageIdPromise to async/await syntax
Wintus Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions src/components/PageTitleInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Suspense, useMemo, useState } from 'react';
import { Suspense, useState } from 'react';
import useDebounce from '../hooks/useDebounce';
import { fetchPageId } from '../services/MediaWikiAPIs';
import { PageIdFetcher } from './PageIdFetcher';
Expand All @@ -15,21 +15,21 @@ export function PageTitleInput({
const [pageTitle, setPageTitle] = useState(initialPageTitle);
const debouncedPageTitle = useDebounce(pageTitle.trim(), 300);

// Note: useMemo callback cannot be async (linter rule), but returning a Promise is fine.
// Semantically equivalent to async/await, but React wants explicit Promise return.
const pageIdPromise = useMemo(() => {
// React Compiler auto-memoizes based on reactive dependencies (wikiUrl, debouncedPageTitle)
const pageIdPromise = (async () => {
// guard
if (!debouncedPageTitle) {
return Promise.resolve({});
return {};
}
// fetch page ID
return fetchPageId(wikiUrl, debouncedPageTitle)
.then((id) => ({ id: id.toString() }))
.catch((error) => {
console.error('Error fetching page ID:', error);
return { error: 'Error fetching page ID. Please try again.' };
});
}, [wikiUrl, debouncedPageTitle]);
try {
const id = await fetchPageId(wikiUrl, debouncedPageTitle);
return { id: id.toString() };
} catch (error) {
console.error('Error fetching page ID:', error);
return { error: 'Error fetching page ID. Please try again.' };
}
})();

return (
<div className="form-group">
Expand Down