Skip to content

Fix PageTitleInput reset on wiki site change #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Wintus merged 1 commit into from
Feb 5, 2026
Merged

Fix PageTitleInput reset on wiki site change #158

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions src/components/SearchForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ export function SearchForm({
<WikiSelector selectedWiki={wikiUrl} onChange={setWikiUrl} />

<PageTitleInput
key={wikiUrl.href}
initialPageTitle={searchState.pageTitle}
wikiUrl={wikiUrl}
/>
Expand Down Expand Up @@ -328,6 +329,36 @@ if (import.meta.vitest) {
expect(wikiSelector.value).toBe('https://ja.wikipedia.org/');
});

it('resets page title input when wiki site changes', async () => {
const { fireEvent } = await import('@testing-library/react');
const user = userEvent.setup();
await act(async () => renderWithQuery(<SearchForm {...defaultProps} />));
const titleInput = screen.getByLabelText(
/Wiki Article Title:/i
) as HTMLInputElement;

// User types a different title
await user.clear(titleInput);
await user.type(titleInput, 'Albert Einstein');
expect(titleInput.value).toBe('Albert Einstein');

// Switch wiki site
const wikiSelector =
screen.getByLabelText<HTMLSelectElement>(/Wiki Site:/i);
await act(async () => {
// use fireEvent due to warning of act unsupported
fireEvent.change(wikiSelector, {
target: { value: 'https://ja.wikipedia.org/' },
});
});

// PageTitleInput remounts → title resets to initialPageTitle
const resetTitleInput = screen.getByLabelText(
/Wiki Article Title:/i
) as HTMLInputElement;
expect(resetTitleInput.value).toBe('Initial Title');
});

it('renders initial values from searchState', async () => {
await act(async () =>
renderWithQuery(
Expand Down