Skip to content

Commit 74ff870

Browse files
committed
tunnel: bump libwg-go and use newer logging function
We also plug a memory leak. C.CString was calling malloc, and these were never freed. Signed-off-by: Jason A. Donenfeld <[email protected]>
1 parent b4f54e8 commit 74ff870

File tree

3 files changed

+45
-47
lines changed

3 files changed

+45
-47
lines changed

tunnel/tools/libwg-go/api-android.go

Lines changed: 32 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -10,15 +10,12 @@ package main
1010
import "C"
1111

1212
import (
13-
"bufio"
14-
"bytes"
15-
"log"
13+
"fmt"
1614
"math"
1715
"net"
1816
"os"
1917
"os/signal"
2018
"runtime"
21-
"strings"
2219
"unsafe"
2320

2421
"golang.org/x/sys/unix"
@@ -29,13 +26,21 @@ import (
2926
)
3027

3128
type AndroidLogger struct {
32-
level C.int
33-
interfaceName string
29+
level C.int
30+
tag *C.char
3431
}
3532

36-
func (l AndroidLogger) Write(p []byte) (int, error) {
37-
C.__android_log_write(l.level, C.CString("WireGuard/GoBackend/"+l.interfaceName), C.CString(string(p)))
38-
return len(p), nil
33+
func cstring(s string) *C.char {
34+
b, err := unix.BytePtrFromString(s)
35+
if err != nil {
36+
b := [1]C.char{}
37+
return &b[0]
38+
}
39+
return (*C.char)(unsafe.Pointer(b))
40+
}
41+
42+
func (l AndroidLogger) Printf(format string, args ...interface{}) {
43+
C.__android_log_write(l.level, l.tag, cstring(fmt.Sprintf(format, args...)))
3944
}
4045

4146
type TunnelHandle struct {
@@ -55,39 +60,38 @@ func init() {
5560
select {
5661
case <-signals:
5762
n := runtime.Stack(buf, true)
63+
if n == len(buf) {
64+
n--
65+
}
5866
buf[n] = 0
59-
C.__android_log_write(C.ANDROID_LOG_ERROR, C.CString("WireGuard/GoBackend/Stacktrace"), (*C.char)(unsafe.Pointer(&buf[0])))
67+
C.__android_log_write(C.ANDROID_LOG_ERROR, cstring("WireGuard/GoBackend/Stacktrace"), (*C.char)(unsafe.Pointer(&buf[0])))
6068
}
6169
}
6270
}()
6371
}
6472

6573
//export wgTurnOn
66-
func wgTurnOn(ifnameRef string, tunFd int32, settings string) int32 {
67-
interfaceName := string([]byte(ifnameRef))
68-
74+
func wgTurnOn(interfaceName string, tunFd int32, settings string) int32 {
75+
tag := cstring("WireGuard/GoBackend/" + interfaceName)
6976
logger := &device.Logger{
70-
Debug: log.New(&AndroidLogger{level: C.ANDROID_LOG_DEBUG, interfaceName: interfaceName}, "", 0),
71-
Info: log.New(&AndroidLogger{level: C.ANDROID_LOG_INFO, interfaceName: interfaceName}, "", 0),
72-
Error: log.New(&AndroidLogger{level: C.ANDROID_LOG_ERROR, interfaceName: interfaceName}, "", 0),
77+
Verbosef: AndroidLogger{level: C.ANDROID_LOG_DEBUG, tag: tag}.Printf,
78+
Errorf: AndroidLogger{level: C.ANDROID_LOG_ERROR, tag: tag}.Printf,
7379
}
7480

75-
logger.Debug.Println("Debug log enabled")
76-
7781
tun, name, err := tun.CreateUnmonitoredTUNFromFD(int(tunFd))
7882
if err != nil {
7983
unix.Close(int(tunFd))
80-
logger.Error.Println(err)
84+
logger.Errorf("CreateUnmonitoredTUNFromFD: %v", err)
8185
return -1
8286
}
8387

84-
logger.Info.Println("Attaching to interface", name)
88+
logger.Verbosef("Attaching to interface %v", name)
8589
device := device.NewDevice(tun, logger)
8690

87-
setError := device.IpcSetOperation(bufio.NewReader(strings.NewReader(settings)))
88-
if setError != nil {
91+
err = device.IpcSet(settings)
92+
if err != nil {
8993
unix.Close(int(tunFd))
90-
logger.Error.Println(setError)
94+
logger.Errorf("IpcSet: %v", err)
9195
return -1
9296
}
9397
device.DisableSomeRoamingForBrokenMobileSemantics()
@@ -96,12 +100,12 @@ func wgTurnOn(ifnameRef string, tunFd int32, settings string) int32 {
96100

97101
uapiFile, err := ipc.UAPIOpen(name)
98102
if err != nil {
99-
logger.Error.Println(err)
103+
logger.Errorf("UAPIOpen: %v", err)
100104
} else {
101105
uapi, err = ipc.UAPIListen(name, uapiFile)
102106
if err != nil {
103107
uapiFile.Close()
104-
logger.Error.Println(err)
108+
logger.Errorf("UAPIListen: %v", err)
105109
} else {
106110
go func() {
107111
for {
@@ -116,7 +120,7 @@ func wgTurnOn(ifnameRef string, tunFd int32, settings string) int32 {
116120
}
117121

118122
device.Up()
119-
logger.Info.Println("Device started")
123+
logger.Verbosef("Device started")
120124

121125
var i int32
122126
for i = 0; i < math.MaxInt32; i++ {
@@ -185,14 +189,11 @@ func wgGetConfig(tunnelHandle int32) *C.char {
185189
if !ok {
186190
return nil
187191
}
188-
settings := new(bytes.Buffer)
189-
writer := bufio.NewWriter(settings)
190-
err := handle.device.IpcGetOperation(writer)
192+
settings, err := handle.device.IpcGet()
191193
if err != nil {
192194
return nil
193195
}
194-
writer.Flush()
195-
return C.CString(settings.String())
196+
return C.CString(settings)
196197
}
197198

198199
//export wgVersion

tunnel/tools/libwg-go/go.mod

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,7 @@ module golang.zx2c4.com/wireguard/android
33
go 1.15
44

55
require (
6-
golang.org/x/crypto v0.0.0-20201221181555-eec23a3978ad // indirect
7-
golang.org/x/net v0.0.0-20201216054612-986b41b23924 // indirect
8-
golang.org/x/sys v0.0.0-20201223074533-0d417f636930
9-
golang.zx2c4.com/wireguard v0.0.20201119-0.20201223215156-09728dc6b340
6+
golang.org/x/net v0.0.0-20210119194325-5f4716e94777 // indirect
7+
golang.org/x/sys v0.0.0-20210124154548-22da62e12c0c
8+
golang.zx2c4.com/wireguard v0.0.20201119-0.20210126220548-d669c78c4306
109
)

tunnel/tools/libwg-go/go.sum

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,22 @@
11
golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2/go.mod h1:djNgcEr1/C05ACkg1iLfiJU5Ep61QUkGW8qpdssI0+w=
2-
golang.org/x/crypto v0.0.0-20200622213623-75b288015ac9/go.mod h1:LzIPMQfyMNhhGPhUkYOs5KpL4U8rLKemX1yGLhDgUto=
3-
golang.org/x/crypto v0.0.0-20201124201722-c8d3bf9c5392/go.mod h1:jdWPYTVW3xRLrWPugEBEK3UY2ZEsg3UU495nc5E+M+I=
42
golang.org/x/crypto v0.0.0-20201221181555-eec23a3978ad h1:DN0cp81fZ3njFcrLCytUHRSUkqBjfTo4Tx9RJTWs0EY=
53
golang.org/x/crypto v0.0.0-20201221181555-eec23a3978ad/go.mod h1:jdWPYTVW3xRLrWPugEBEK3UY2ZEsg3UU495nc5E+M+I=
64
golang.org/x/net v0.0.0-20190404232315-eb5bcb51f2a3/go.mod h1:t9HGtf8HONx5eT2rtn7q6eTqICYqUVnKs3thJo3Qplg=
7-
golang.org/x/net v0.0.0-20201110031124-69a78807bb2b/go.mod h1:sp8m0HH+o8qH0wwXwYZr8TS3Oi6o0r6Gce1SSxlDquU=
8-
golang.org/x/net v0.0.0-20201216054612-986b41b23924 h1:QsnDpLLOKwHBBDa8nDws4DYNc/ryVW2vCpxCs09d4PY=
9-
golang.org/x/net v0.0.0-20201216054612-986b41b23924/go.mod h1:m0MpNAwzfU5UDzcl9v0D8zg8gWTRqZa9RBIspLL5mdg=
5+
golang.org/x/net v0.0.0-20201224014010-6772e930b67b h1:iFwSg7t5GZmB/Q5TjiEAsdoLDrdJRC1RiF2WhuV29Qw=
6+
golang.org/x/net v0.0.0-20201224014010-6772e930b67b/go.mod h1:m0MpNAwzfU5UDzcl9v0D8zg8gWTRqZa9RBIspLL5mdg=
7+
golang.org/x/net v0.0.0-20210119194325-5f4716e94777 h1:003p0dJM77cxMSyCPFphvZf/Y5/NXf5fzg6ufd1/Oew=
8+
golang.org/x/net v0.0.0-20210119194325-5f4716e94777/go.mod h1:m0MpNAwzfU5UDzcl9v0D8zg8gWTRqZa9RBIspLL5mdg=
109
golang.org/x/sys v0.0.0-20190215142949-d0b11bdaac8a/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY=
11-
golang.org/x/sys v0.0.0-20190412213103-97732733099d/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
1210
golang.org/x/sys v0.0.0-20191026070338-33540a1f6037/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
13-
golang.org/x/sys v0.0.0-20200930185726-fdedc70b468f/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
1411
golang.org/x/sys v0.0.0-20201119102817-f84b799fce68/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
15-
golang.org/x/sys v0.0.0-20201126233918-771906719818/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
16-
golang.org/x/sys v0.0.0-20201223074533-0d417f636930 h1:vRgIt+nup/B/BwIS0g2oC0haq0iqbV3ZA+u6+0TlNCo=
17-
golang.org/x/sys v0.0.0-20201223074533-0d417f636930/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
12+
golang.org/x/sys v0.0.0-20210105210732-16f7687f5001 h1:/dSxr6gT0FNI1MO5WLJo8mTmItROeOKTkDn+7OwWBos=
13+
golang.org/x/sys v0.0.0-20210105210732-16f7687f5001/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
14+
golang.org/x/sys v0.0.0-20210124154548-22da62e12c0c h1:VwygUrnw9jn88c4u8GD3rZQbqrP/tgas88tPUbBxQrk=
15+
golang.org/x/sys v0.0.0-20210124154548-22da62e12c0c/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
1816
golang.org/x/term v0.0.0-20201117132131-f5c789dd3221/go.mod h1:Nr5EML6q2oocZ2LXRh80K7BxOlk5/8JxuGnuhpl+muw=
1917
golang.org/x/term v0.0.0-20201126162022-7de9c90e9dd1/go.mod h1:bj7SfCRtBDWHUb9snDiAeCFNEtKQo2Wmx5Cou7ajbmo=
2018
golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=
2119
golang.org/x/text v0.3.3/go.mod h1:5Zoc/QRtKVWzQhOtBMvqHzDpF6irO9z98xDceosuGiQ=
2220
golang.org/x/tools v0.0.0-20180917221912-90fa682c2a6e/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ=
23-
golang.zx2c4.com/wireguard v0.0.20201119-0.20201223215156-09728dc6b340 h1:X6jrf2sUEj3n+q2oB/I3C088vQFKREz2UzgVJ8wENtI=
24-
golang.zx2c4.com/wireguard v0.0.20201119-0.20201223215156-09728dc6b340/go.mod h1:ITsWNpkFv78VPB7f8MiyuxeEMcHR4jfxHGCJLPP3GHs=
21+
golang.zx2c4.com/wireguard v0.0.20201119-0.20210126220548-d669c78c4306 h1:z7W9tlhU/KwkZWSX6QCfZXBcDpIa1JYANldQ/gFJj44=
22+
golang.zx2c4.com/wireguard v0.0.20201119-0.20210126220548-d669c78c4306/go.mod h1:r0ExowOoGFfDoLDxx+M9SYbNVsoZ0xviLL+K4f2mt+A=

0 commit comments

Comments
 (0)