ui: support DNS SRV lookup & show resolved inetendpoint #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason A. Donenfeld <[email protected]>
Signed-off-by: panxuesen <[email protected]>
zx2c4-bot
force-pushed
the
master
branch
4 times, most recently
from
c1d59a2 to
6aab7cc
Compare
msfjarvis
requested changes
Sep 19, 2025
Comment on lines
+120
to
+121
| final Resolver resolver1 = new SimpleResolver("223.5.5.5"); | ||
| final Resolver resolver2 = new SimpleResolver("223.6.6.6"); |
There was a problem hiding this comment.
Not sure we want Alibaba Cloud to be the DNS resolver for everyone
| break; | ||
| } | ||
| } else { | ||
| System.out.println("SRV lookup failed: " + lookup.getErrorString()); |
There was a problem hiding this comment.
This should be using android.util.Log
| System.out.println("SRV lookup failed: " + lookup.getErrorString()); | ||
| } | ||
| } catch (final TextParseException | UnknownHostException e) { | ||
| System.out.println("SRV lookup failed: " + e.getMessage()); |
| resolved = new InetEndpoint(address.getHostAddress(), true, targetPort[0]); | ||
| lastResolution = Instant.now(); | ||
| } catch (final UnknownHostException e) { | ||
| System.out.println("DNS lookup failed: " + e.getMessage()); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.