Improve Windows compatibility for port generation#248
Open
denini08 wants to merge 1 commit intoWisconsinAIVision:masterfrom
Open
Improve Windows compatibility for port generation#248denini08 wants to merge 1 commit intoWisconsinAIVision:masterfrom
denini08 wants to merge 1 commit intoWisconsinAIVision:masterfrom
Conversation
denini08
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #235
The current port generation code uses
os.getuid()which is not available on Windows, causing the application to crash.This PR adds a cross-platform solution that:
os.getuid()on Unix/Linux systemsgetpass.getuser()on WindowsBoth approaches generate a user-specific port number as intended.