Add support for Node v25 and Electron 39+ prebuilds #1422
+97
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unning those prebuilds with bookworm (and keeping the older prebuilds on bullseye). Fixes WiseLibs#1421
mceachen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's now a "LEGACY" and "MODERN" set of node and electron versions. Only node v25 and electron v39 are "MODERN", and those prebuilds use bookworm. The older node and electron versions stay on bullseye. Fixes #1421 and #1412
Before I did this
hacksolution, I looked a bit at installing a newer g++ on the old bullseye Debian image, but I think that gets rough quickly -- it's not the glibc that people will expect.I think we should only support prebuilds on recent Debian/Ubuntu distros for node v25+/ electron v39+ (unless I'm missing something!)