-
Notifications
You must be signed in to change notification settings - Fork 34
[Mariana Ruddy] Desafio 2 #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
LGTM 👍 |
glaucia86
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
meudesafio/page.html
Outdated
| <div class="transition"></div> | ||
| <section class="welcome-wrapper"> | ||
| <div class="carousel"> | ||
| <div class="carousel-welcome"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marianaruddy para a sua duvida do background da imagem.
o background dela já é uma imagem, então uma maneira de mudar sua cor seria criando outra div em cima dela
e mudando sua transparencia .
Exemplo
`.carousel-welcom {
background: url(../images/Slider.png) repeat-x 0% center;
}
.containerEmcimaDeCarousel{
position: absolute;
top: 0;
left: 0;
width: 100%;
height: 100%;
background: #fb1655;
opacity: 0.85;
}`
meudesafio/page.html
Outdated
| /></a> | ||
| <nav class="menu-itens"> | ||
| <a class="menu-item" href=""><span>Home</span></a> | ||
| <a class="menu-item" href=""><span>Serviços</span></a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
você pode fazer seu portfolio navegar entre seções e deixa-lo mais interativo mudando seu href para o id da sua seção exemplo :
href="#servicos"
meudesafio/page.html
Outdated
| >In aliquet vitae dui vitae efficitur. Donec non convallis enim. | ||
| </span> | ||
| </div> | ||
| <div class="service"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
o href="#servicos" seta para o id servicos, então sua div ficaria assim :
<div class="service" id ="servicos">
estou meio confusa com o git entao acabei criando outro pr para o desafio 2, acho que consertei ja todos os comentarios feitos no pr do desafio 1
@LorTrindade @glaucia86
pull request do desafio 1:
https://github.com/WoMakersCode/front-end-study-group-rj/pull/15