Css #30
Open
Css #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
happymoon
reviewed
Sep 2, 2019
| <title>Portifólio - MySite</title> | ||
| <!-- <meta charset="utf-8"/> --> | ||
|
|
||
| <meta name="author" content="Nayara"> |
There was a problem hiding this comment.
Nayara, essas tags precisam ser fechadas, pra isso basta colocar barra no final, exemplo:
<meta name="application-name" content="Desenvolvimento Profissional" />
happymoon
reviewed
Sep 2, 2019
|
|
||
| <main> | ||
| <!--<div class="teste"></div>--> | ||
| <div id="home"> |
There was a problem hiding this comment.
Nesse caso aqui, não tem muito sentido você utilizar tanto o <div> quanto o <section>, você pode usar só o
happymoon
reviewed
Sep 2, 2019
| <div id="email"><a href="mailto:[email protected]">[email protected]</a></div> | ||
|
|
||
| <div id="phone"> | ||
| <a href="tel:+5522999999999">+55 22 999999999</a> |
happymoon
reviewed
Sep 2, 2019
happymoon
left a comment
happymoon
left a comment
There was a problem hiding this comment.
Oi Nayara, parabéns! Seu código está bem estruturado e limpo. Alteraria umas coisinhas aqui e alí, mas são apenas abordagens diferentes de se fazer a mesma coisa, não tem nada errado, de fato.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desafio Parte 2: meu css.