-
Notifications
You must be signed in to change notification settings - Fork 34
Desafio #1 - Estruturação do Template com HTML5 #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Desafio #1 - Estruturação do Template com HTML5 #4
Conversation
| <body> | ||
| <nav> | ||
| <!-- TODO: modificar os tamanhos com css --> | ||
| <img src="../images/logo.png" alt="logo" height="50px"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Não é necessário especificar a medida dentro de atributos de imagem. Referência: https://www.w3schools.com/tags/tag_img.asp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eu acabei colocando pq a imagem estava muito grande no HTML, coloquei só de forma temporária mesmo por isso deixei o TODO ai em cima
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Me referi à unidade de medida px (pixel), não é necessário informar as medidas nesse atributo, bastaria height="50"
| <p>+55 21 66666-666</p> | ||
|
|
||
| <h3>Mídias</h3> | ||
| <hr/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Semanticamente o <hr> tem a função de separar áreas que abordam conteúdos com temas diferentes e não deveria ser usado apenas por questões visuais. Referência: https://www.w3schools.com/tags/tag_hr.asp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm.. então essa linha é só com CSS mesmo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idealmente sim, não há motivo para gerar elementos extras de html se eles não tem valor semântico.
Inclusão do título
Inclusão do link para o Desafio WoMakersCode#2
…ndrade/front-end-study-group-rj into feature/html5-challenge-1
No description provided.