Skip to content

Conversation

@gabiascarso
Copy link

No description provided.

Copy link
Author

@gabiascarso gabiascarso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tarcilas tarcilas closed this Dec 16, 2018
@tarcilas tarcilas reopened this Dec 16, 2018
site.html Outdated
<section>
<h1>Serviços</h1>
<p>Lorem ipsum dolor sit amet, consectetur adipiscing elit. Donec euismod diam eget ex rhoncus, sed.</p>
<hr />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Semanticamente o <hr> tem a função de separar áreas que abordam conteúdos com temas diferentes e não deveria ser usado apenas por questões visuais. Referência: https://www.w3schools.com/tags/tag_hr.asp

site.html Outdated
<section>
<h1>Meus Trabalhos</h1>
<p>Lorem ipsum dolor sit amet, consectetur adipiscing elit. Sed varius consectetur felis ut condimentum. Aliquam.</p>
<hr />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️

site.html Outdated
</ul>
</nav>
<article>
<img src="images/Portfolio01.png" height= "250px" alt="Portolio01" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Não é necessário especificar a medida px (pixel) nos atributos do elemento <img>

Suggested change
<img src="images/Portfolio01.png" height= "250px" alt="Portolio01" />
<img src="images/Portfolio01.png" height= "250" alt="Portolio01" />

site.html Outdated
<p>Lorem ipsum...</p>
</article>
<article>
<img src="images/Portfolio02.png" height= "250px" alt="Portfolio02" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<img src="images/Portfolio02.png" height= "250px" alt="Portfolio02" />
<img src="images/Portfolio02.png" height= "250" alt="Portfolio02" />

site.html Outdated
<p>Lorem ipsum...</p>
</article>
<article>
<img src="images/Portfolio03.png" height= "250px" alt="Portfolio03" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<img src="images/Portfolio03.png" height= "250px" alt="Portfolio03" />
<img src="images/Portfolio03.png" height= "250" alt="Portfolio03" />

site.html Outdated
<section>
<h1>Quem sou eu</h1>
<p>Lorem ipsum dolor sit amet, consectetur adipiscing elit. Aenean quis dui malesuada purus aliquet accumsan.</p>
<hr />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️

site.html Outdated
<h2>Sobre mim</h2>
<p>Lorem ipsum dolor sit amet, consectetur adipiscing elit. Curabitur id felis vestibulum, laoreet ligula sed, fermentum libero. In blandit tristique leo id dictum. Nullam gravida vulputate ipsum. Nulla vel lacus sapien. Praesent dapibus mi justo, nec fringilla nisi congue quis. Suspendisse at sapien nec odio gravida placerat. Aliquam iaculis quis dui et ullamcorper. Vestibulum id dui tempus, feugiat velit non, bibendum leo. Nam in mollis libero. In sit amet diam in mauris sodales tincidunt et quis velit. Ut sed odio nec erat eleifend mollis vitae.</p>
</div>
<div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aqui você poderia usar o <article>, da mesma forma que fez mais acima.

site.html Outdated
<section>
<h1>Contato</h1>
<p>Lorem ipsum dolor sit amet, consectetur adipiscing elit. Phasellus id enim vitae quam suscipit porta.</p>
<hr />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️

site.html Outdated
<p>Lorem ipsum dolor sit amet, consectetur adipiscing elit. Phasellus id enim vitae quam suscipit porta.</p>
<hr />
<div>
<p>[email protected]</p>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Você pode facilitar a vida do teu usuário colocando seu email clicável.

Suggested change

site.html Outdated
<hr />
<div>
<p>[email protected]</p>
<p>+55 21 98765-4321</p>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mesma coisa do email também vale para telefones.
Referência: https://www.w3schools.com/tags/tag_a.asp

Suggested change
<p>+55 21 98765-4321</p>
<a href="tel:+5521987654321">+55 21 98765-4321</a>

site.html Outdated
<p>+55 21 98765-4321</p>
</div>
<h2>Mídias</h2>
<hr />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️

site.html Outdated
<hr />
</section>
<footer>
<p>Women + Tech = < /strong> </p>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐️ Pra exibir caracteres especiais é importante usar uma grafia diferente para que eles não sejam confundidos com elementos funcionais do código. Link de referência: https://css-tricks.com/snippets/html/glyphs/

Suggested change
<p>Women + Tech = < /strong> </p>
<p>Women + Tech = &lt;/strong&gt; </p>

@happymoon happymoon self-requested a review December 16, 2018 18:51
Copy link
Contributor

@tarcilas tarcilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muito bom! Fico muito feliz com seu engajamento no desafio, mesmo não tendo ido no evento.

@@ -0,0 +1,123 @@

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Como o site só terá uma página mesmo, melhor renomear o arquivo para o padrão: index.html

site.html Outdated
<nav>
<ul>
<li><a href=""><img src="images/logo.png" width= "160" height= "50"/></a></li>
<li><a href="">HOME</a></li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Colocar a referência para as respectivas seções

<figure>
<img src="images/Slider.png" alt="Image-Slider" width="100%" height="100%"/>
<figcaption>
<h1>BEM VIND@</h1>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Não acho muito adequando colocar tudo isso dentro da tag figcaption, ela é mais usada para uma breve descrição da figura
https://www.w3schools.com/tags/tag_figcaption.asp

site.html Outdated
<hr />
<article>
<img src="images/Service1.png" alt="Service1" />
<h3>Websites</h3>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

É uma boa prática respeitar a hierarquia dos Headings h1, h2, h3..., não usar só por causa do tamanho da fonte, pois isso depois será mudado na aplicação de estilos

<p>Lorem ipsum...</p>
</section>
<section>
<h1>Quem sou eu</h1>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seria legal já customizar os textos, foto, contatos e redes sociais com suas informações, afinal esse será seu portfólio.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vou fazer na parte 2 do desafio!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants