-
Notifications
You must be signed in to change notification settings - Fork 34
Desafio Front-End Study Group #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@tarcilas @happymoon |
index.html
Outdated
| <img src="./images/slider01.png"> | ||
| </figure> | ||
| <p> | ||
| OUTRO TEXTO AQUI! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Esse texto é relacionado à imagem acima? Então pode usar o <figcaption> nesse caso.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| OUTRO TEXTO AQUI! | |
| <div id="primeiro-slide"> | |
| <figure> | |
| <img src="./images/slider01.png"> | |
| <figcaption>OUTRO TEXTO AQUI!</figcaption> | |
| </figure> |
index.html
Outdated
| <p>Precisando tirar aquela ideia do papel? Procurando um bom profissional para desenvolver seu site? Fale | ||
| comigo!</p> | ||
| <div id="linha"> | ||
| <hr /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
o <hr> visualmente gera uma linha, porém semanticamente ele tem a função de separar áreas que abordam conteúdos com temas diferentes e não deveria ser usado apenas por questões visuais. Referência: https://www.w3schools.com/tags/tag_hr.asp
E no caso dele ser utilizado da forma correta, não requer nenhum elemento em volta dele, já que ele pode ser estilizado via CSS, bastando referenciá-lo:
hr {atributo: valor;}
Obs: este comentário vale para todos os <hr> que você utilizou no seu código. 💁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Certo! Então posso fazer essa linha utilizando CSS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pode e deve, basta colocar uma borda num elemento próximo, supondo que você use o parágrafo que está logo acima, basta colocar um border-bottom nele.
index.html
Outdated
| <figcaption>Daiane Alves</figcaption> | ||
| </figure> | ||
|
|
||
| <table> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tabelas devem ser usadas somente para exibir conteúdo em formato de dados tabelados e não para estruturar código.
index.html
Outdated
| <figcaption>Daiane Alves</figcaption> | ||
| </figure> | ||
|
|
||
| <table> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <table> | |
| <ul class="redes-sociais"> | |
| <li><a href="https://www.facebook.com/DaianeAlvesRJ"><img src="./images/facebook.png" title="facebook" /></a></li> | |
| <li><a href="https://www.instagram.com/daianealvesrj/"><img src="./images/instagram.png" title="instagram" /></a></li> | |
| <li><a href="https://twitter.com/daianealvesrj"><img src="./images/twitter.png" title="twitter" /></a></li> | |
| </ul> |
| </div> | ||
|
|
||
| <div id="habilidades"> | ||
| <ul> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Não seria mais prático colocar o id="habilidades" direto no elemento <ul> e eliminar esse <div>? ❓
index.html
Outdated
| <div id="linha-menor"> | ||
| <hr /> | ||
| </div> | ||
| <table> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 <table>
index.html
Outdated
| <section id="contato"> | ||
| <h1>Contato</h1> | ||
| <p>Precisando de ajuda para tirar aquela ideia do papel? Vamos bater um papo?</p> | ||
| <div id="linha"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
index.html
Outdated
| <section id="quem-sou-eu"> | ||
| <h1>Quem sou eu?</h1> | ||
| <p>Grande incentivadora de movimentos de apoio ao software livre.</p> | ||
| <div id="linha"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-Authored-By: DaianeAlvesRJ <[email protected]>
…oup-rj into desafio
Co-Authored-By: DaianeAlvesRJ <[email protected]>
Co-Authored-By: DaianeAlvesRJ <[email protected]>
tarcilas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ótimo trabalho! Parabéns, não espera menos de você.
Co-Authored-By: DaianeAlvesRJ <[email protected]>
|
Obrigada pela força e apoio, @tarcilas |
Estrutura do site em HTML.