Skip to content

Bugfix/sidebar13 #1386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KMDaily merged 2 commits into from
Feb 10, 2026
Merged

Bugfix/sidebar13 #1386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60d1dba
Bugfix: asking for the app container may occur before CellTags gets a…
KMDaily Feb 9, 2026
755579d
Bugfix: avoid recursion when downloading vector databases
KMDaily Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Source/Chatbook/Actions.wl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1340,6 +1340,9 @@ resolveAppContainer[ c_CellObject, nbo_NotebookObject ] := Enclose[
ParentCell @ c,
MemberQ[ tags, Alternatives[ "SidebarTopCell" ] ],
ParentCell @ ParentCell @ c,
(* new SidebarTopCell from sending a chat has uuid as a temporary cell tag, but asking for app container may occur before it gets a "real" cell tag *)
StringMatchQ[ First[ tags, "" ], RegularExpression["[A-Za-z0-9]{8}\\-[A-Za-z0-9]{4}\\-[A-Za-z0-9]{4}\\-[A-Za-z0-9]{4}\\-[A-Za-z0-9]{12}"] ],
ParentCell @ ParentCell @ c,
True,
None
],
Expand Down
4 changes: 2 additions & 2 deletions Source/Chatbook/PromptGenerators/VectorDatabases.wl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -551,7 +551,7 @@ downloadVectorDatabases[ dir0_, urls0_Association ] := Enclose[
$extraDownloadTasks = Internal`Bag[ ];

dir = ConfirmBy[ GeneralUtilities`EnsureDirectory @ dir0, DirectoryQ, "Directory" ];
cleanupLegacyVectorDBFiles @ dir;
(* cleanupLegacyVectorDBFiles @ dir; *) (* function not defined *)

(* Try unpacking any zip files that might be left over from previous install attempts: *)
Quiet @ catchAlways @ tryUnpackingVectorDatabases @ dir;
Expand Down Expand Up @@ -775,7 +775,7 @@ setDownloadProgress[ name_String ] :=
setDownloadProgress[ name, ## ] &;

setDownloadProgress[ name_, KeyValuePattern[ "ByteCountDownloaded" -> b_? Positive ] ] := (
Internal`YieldAsynchronousTask[ ];
(* Internal`YieldAsynchronousTask[ ]; *) (* causes recursion *)
$downloadProgress[ name ] = b
);

Expand Down
Loading