Remove unnecessary CombinedConditionProvider.

Implement the function `withConditionsFrom()` to transfer conditions from another provider.

Author: Cyperghost

wcfsetup/install/files/lib/system/condition/provider/AbstractConditionProvider.class.php

@@ -78,4 +78,13 @@ public function getConditionTypes(): array
     {
         return $this->conditionTypes;
     }
+
+    public function withConditionsFrom(AbstractConditionProvider $provider): self
+    {
+        foreach ($provider->getConditionTypes() as $conditionType) {
+            $this->addCondition($conditionType);
+        }
+
+        return $this;
+    }
 }

wcfsetup/install/files/lib/system/condition/provider/combined/CombinedConditionProvider.class.php

@@ -14,15 +14,13 @@
  *
  * @phpstan-import-type RequestConditionType from RequestConditionProvider
  * @phpstan-import-type UserConditionType from UserConditionProvider
- * @extends CombinedConditionProvider<UserConditionType|RequestConditionType, AbstractConditionProvider<UserConditionType>|AbstractConditionProvider<RequestConditionType>>
+ * @extends AbstractConditionProvider<UserConditionType|RequestConditionType>
  */
-final class NoticeConditionProvider extends CombinedConditionProvider
+final class NoticeConditionProvider extends AbstractConditionProvider
 {
     public function __construct()
     {
-        parent::__construct(
-            new UserConditionProvider(),
-            new RequestConditionProvider(),
-        );
+        $this->withConditionsFrom(new UserConditionProvider());
+        $this->withConditionsFrom(new RequestConditionProvider());
     }
 }