Rudimentary support for PHP 8.5

See #6490

Author: dtdesign

wcfsetup/install/files/lib/data/menu/item/MenuItemNodeTree.class.php

@@ -104,15 +104,14 @@ public function __construct($menuID, ?MenuItemList $menuItemList = null, $checkV
         }
 
         // build menu structure
-        foreach ($menuItemList as $menuItem) {
+        foreach ($menuItemList->getObjects() as $menuItem) {
             $menuItem->cachePageObject();
 
             $this->menuItems[$menuItem->itemID] = $menuItem;
 
-            if (!isset($this->menuItemStructure[$menuItem->parentItemID])) {
-                $this->menuItemStructure[$menuItem->parentItemID] = [];
-            }
-            $this->menuItemStructure[$menuItem->parentItemID][] = $menuItem->itemID;
+            $parentItemID = $menuItem->parentItemID ?? '';
+            $this->menuItemStructure[$parentItemID] ??= [];
+            $this->menuItemStructure[$parentItemID][] = $menuItem->itemID;
         }
 
         // generate node tree
@@ -150,7 +149,7 @@ protected function generateNodeTree($parentID = null, ?MenuItemNode $parentNode
     {
         $nodes = [];
 
-        $itemIDs = ($this->menuItemStructure[$parentID] ?? []);
+        $itemIDs = ($this->menuItemStructure[$parentID ?? ''] ?? []);
         foreach ($itemIDs as $itemID) {
             $menuItem = $this->menuItems[$itemID];
 

wcfsetup/install/files/lib/data/page/PageCache.class.php

@@ -48,12 +48,13 @@ public function getPages()
 
     /**
      * Returns a page by page id or null.
-     *
-     * @param int $pageID page id
-     * @return  Page|null
      */
-    public function getPage($pageID)
+    public function getPage(?int $pageID): ?Page
     {
+        if ($pageID === null) {
+            return null;
+        }
+
         return $this->cache['pages'][$pageID] ?? null;
     }
 

wcfsetup/install/files/lib/system/database/MySQLDatabase.class.php

@@ -30,9 +30,16 @@ public function connect()
 
         try {
             $driverOptions = $this->defaultDriverOptions;
-            $driverOptions[\PDO::MYSQL_ATTR_INIT_COMMAND] = "SET NAMES 'utf8mb4'";
+            $initCommand = "SET NAMES 'utf8mb4'";
             if (!$this->failsafeTest) {
-                $driverOptions[\PDO::MYSQL_ATTR_INIT_COMMAND] = "SET NAMES 'utf8mb4', SESSION sql_mode = 'ANSI,ONLY_FULL_GROUP_BY,STRICT_ALL_TABLES,NO_ZERO_IN_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_ENGINE_SUBSTITUTION'";
+                $initCommand = "SET NAMES 'utf8mb4', SESSION sql_mode = 'ANSI,ONLY_FULL_GROUP_BY,STRICT_ALL_TABLES,NO_ZERO_IN_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_ENGINE_SUBSTITUTION'";
+            }
+
+            if (\defined('\\Pdo\\Mysql::ATTR_INIT_COMMAND')) {
+                // @phpstan-ignore class.notFound
+                $driverOptions[\Pdo\Mysql::ATTR_INIT_COMMAND] = $initCommand;
+            } else {
+                $driverOptions[\PDO::MYSQL_ATTR_INIT_COMMAND] = $initCommand;
             }
 
             // disable prepared statement emulation since MySQL 5.1.17 is the minimum required version
@@ -81,7 +88,13 @@ public static function isSupported()
     protected function setAttributes()
     {
         parent::setAttributes();
-        $this->pdo->setAttribute(\PDO::MYSQL_ATTR_USE_BUFFERED_QUERY, true);
+
+        if (\defined('\\Pdo\\Mysql::ATTR_USE_BUFFERED_QUERY')) {
+            // @phpstan-ignore class.notFound
+            $this->pdo->setAttribute(\Pdo\Mysql::ATTR_USE_BUFFERED_QUERY, true);
+        } else {
+            $this->pdo->setAttribute(\PDO::MYSQL_ATTR_USE_BUFFERED_QUERY, true);
+        }
     }
 
     /**