Skip to content

Eager and Tolerant Caching#6237

Merged
Cyperghost merged 44 commits into6.2from
6.2-tolerant-cache
Mar 18, 2025
Merged

Eager and Tolerant Caching#6237
Cyperghost merged 44 commits into6.2from
6.2-tolerant-cache

Conversation

@Cyperghost
Copy link
Contributor

@Cyperghost Cyperghost commented Feb 21, 2025 •
edited
Loading

Closes #5911

Cyperghost and others added 30 commits February 20, 2025 09:53
@Cyperghost
Basic eager cache implementation
1ea6e8f
@Cyperghost
Remove unnecessary IEagerCache
2dde79e
@Cyperghost
Implement the core object cache as an eager cache
7378ebc
@Cyperghost
Implement the language cache as an eager cache
86d2c0c
@Cyperghost
Rename function getCategoryByID() to getLanguageCategoryByID()
7b111be
@Cyperghost
Remove old LanguageCacheBuilder
4f1c295
@Cyperghost
Use more unique function names in AbstractEagerCache
e471fae
@Cyperghost
Always use the current language cache
867b722
@Cyperghost
Disabled flag must be reset beforehand, otherwise the default languag…
b3f827b 
…e cannot be loaded in the `LanguageCache`.
@Cyperghost
Do not use the members that have not been set(null).
09a81d3
@Cyperghost
Prevent access to uninitialized members or static variables
fa8d284
@Cyperghost
Clean up code
eeafaec
@Cyperghost
Use the cache data directly instead of always fetching the current ca…
3313287 
…che data and working with it
@Cyperghost
Use helper functions of LanguageCacheData
5ebecc0
@Cyperghost
Change default value to null
a81e06a
@Cyperghost
Implementation of a legacy cache builder for the migrated caches to t…
1992e18 
…he eager cache
@Cyperghost
MaxLifetime is no longer needed and mapped to zero(0)
67589a1
@Cyperghost
simplify the code
9e645ac
@Cyperghost
simplify the code
5b956a2
@Cyperghost
Ensure that Eager caches are only created once at runtime for the sam…
b7d0b6e 
…e parameters
@Cyperghost @dtdesign
Apply suggestions from code review
0c572ae 
Co-authored-by: Alexander Ebert <ebert@woltlab.com>
@Cyperghost
Implement ICacheSource::getCacheLifetime()`
d0732ff
@Cyperghost
Implement AbstractTolerantCache and the background job for it
4cacf60
@Cyperghost
Remove indentation in copyright block
b4c1de2
@Cyperghost
Add php doc for AbstractLegacyCacheBuilder::$cache
422f572
@Cyperghost
Use \RuntimeException instead of SystemException
77919e3
@Cyperghost
Remove the Language from all functions that are used for the langua…
1837afe 
…ge categories
@Cyperghost
Use the code only when in WCFSetup
9ba8815
@Cyperghost
Implement WhoWasOnlineCache as tolerant cache
29b3e3f
@Cyperghost
Implement UserBirthdayCache as tolerant cache
3cad83b
@Cyperghost Cyperghost requested a review from dtdesign February 21, 2025 14:25
dtdesign
dtdesign requested changes Feb 21, 2025
View reviewed changes
@Cyperghost Cyperghost requested a review from dtdesign February 21, 2025 18:38
@Cyperghost
Merge branch '6.2' into 6.2-tolerant-cache
95bf441 
# Conflicts:
#	wcfsetup/install/files/lib/system/cache/builder/LanguageCacheBuilder.class.php
#	wcfsetup/install/files/lib/system/language/LanguageFactory.class.php
@Cyperghost
Use probabilistic early expiration for tolerant cache
91165bc
@Cyperghost Cyperghost changed the base branch from 6.2-overhaul-caching to 6.2 March 17, 2025 14:02
@Cyperghost Cyperghost marked this pull request as ready for review March 18, 2025 08:17
@Cyperghost Cyperghost changed the title Tolerant caching Eager and Tolerant Caching Mar 18, 2025
@Cyperghost Cyperghost merged commit b08bb88 into 6.2 Mar 18, 2025
7 checks passed
@Cyperghost Cyperghost deleted the 6.2-tolerant-cache branch March 18, 2025 09:15
@Cyperghost Cyperghost mentioned this pull request Mar 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dtdesign dtdesign dtdesign approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Cyperghost @dtdesign

Comments