Only load the file to the attachments if it is actually needed

[Cyperghost]

This ensures that when AttachmentList::loadFiles() is called, the files are not loaded individually from the database. This happens by calling $attachment->fileID, which corresponds to $attachment->__get('fileID').

WCF/wcfsetup/install/files/lib/data/attachment/AttachmentList.class.php

Lines 41 to 72 in 948bdbf

	private function loadFiles(): void
	{
	$fileIDs = [];
	foreach ($this->objects as $attachment) {
	if ($attachment->fileID) {
	$fileIDs[] = $attachment->fileID;
	}
	}
	if ($fileIDs === []) {
	return;
	}
	$fileList = new FileList();
	$fileList->getConditionBuilder()->add("fileID IN (?)", [$fileIDs]);
	$fileList->readObjects();
	$files = $fileList->getObjects();
	$thumbnailList = new FileThumbnailList();
	$thumbnailList->getConditionBuilder()->add("fileID IN (?)", [$fileIDs]);
	$thumbnailList->readObjects();
	foreach ($thumbnailList as $thumbnail) {
	$files[$thumbnail->fileID]->addThumbnail($thumbnail);
	}
	foreach ($this->objects as $attachment) {
	$file = $files[$attachment->fileID] ?? null;
	if ($file !== null) {
	$attachment->setFile($file);
	}
	}
	}