Migrate conversation list to ListView#215
Merged
Cyperghost merged 25 commits into6.2-form-builderfrom Jul 1, 2025
Merged
Conversation
BurntimeX
requested changes
Jun 30, 2025
Member
There was a problem hiding this comment.
- Please move the static methods in
ConversationAddFormto a trait and make themprotected. The trait can then be used byAddParticipantConversationDialogAction. A form should never provide functions for other controllers (except inheritance). -
ts/WoltLabSuite/Core/Conversation/Ui/Subject/Editor.tsis obsolete and can be deleted (+ the corresponding Javascript file).
files/lib/event/interaction/bulk/user/ConversationBulkInteractionCollecting.class.php
Outdated
Show resolved
Hide resolved
files/lib/event/interaction/user/ConversationInteractionCollecting.class.php
Outdated
Show resolved
Hide resolved
files/lib/event/listView/user/ConversationListViewInitialized.class.php
Outdated
Show resolved
Hide resolved
files/lib/system/endpoint/controller/core/conversations/CloseConversation.class.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Marcel Werk <burntime@woltlab.com>
…onversation.class.php Co-authored-by: Marcel Werk <burntime@woltlab.com>
…ConversationForm`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #199
Require #211
Require WoltLab/WCF#6369