fix: remove hardcoded cuda:0 in OTA loss for multi-GPU support#2146
Open
Mr-Neutr0n wants to merge 1 commit intoWongKinYiu:mainfrom
Open
fix: remove hardcoded cuda:0 in OTA loss for multi-GPU support#2146Mr-Neutr0n wants to merge 1 commit intoWongKinYiu:mainfrom
Mr-Neutr0n wants to merge 1 commit intoWongKinYiu:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
The OTA loss computation hardcodes
cuda:0for tensor allocation, causing failures during multi-GPU (DDP) training when the model runs on other GPUs.In
utils/loss.py, several locations use.cuda()ordevice='cuda:0'when creating tensors, which forces them onto GPU 0 regardless of where the model and input data reside. This causes device mismatch errors during distributed training.Fix
Replaced hardcoded device references with dynamic device inference from input tensors:
.cuda()→.to(logits.device)inRankSort,aLRPLoss, andAPLossforward methodsdevice='cuda:0'→device=targets.deviceinbuild_targetsandbuild_targets2methodsThis is consistent with how device handling is already done elsewhere in the same file (e.g.,
torch.ones(7, device=targets.device)).