Fix the class description for ConstantsHelper and ListHelper #2540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous description contained information about the ContextHelper class.
jrfnl
reviewed
Jul 14, 2025
Member
jrfnl
left a comment
jrfnl
left a comment
There was a problem hiding this comment.
@rodrigoprimo Good catch on the copy/pasta ! I just have one suggestion.
Co-authored-by: Juliette <[email protected]>
Collaborator
Author
|
Thanks for your suggestion, @jrfnl! I just approved it. |
jrfnl
approved these changes
Jul 14, 2025
GaryJones
approved these changes
Jul 15, 2025
Member
|
Not merged as the |
dingo-d
approved these changes
Jul 15, 2025
Member
@GaryJones Maybe we should document things like that in the CONTRIBUTING guide ? As far as I'm concerned and with three approvals, this is ready, so I'll merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on an unrelated task, I noticed that the class description in the docblock for the
ConstantsHelperandListHelperclasses was incorrect. The previous description contained information about theContextHelperclass. This PR fixes that.